diff options
author | reed <reed@google.com> | 2016-04-03 09:11:13 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-04-03 09:11:13 -0700 |
commit | 60c9b58b3214b0154c931656e91e39b230e987d8 (patch) | |
tree | 6dd59cf90dd96a443a50ae4b6fa14be6f778c823 /tests | |
parent | cf9bafceafaf6c0bf8b0eac8de509aa1d8407fca (diff) |
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002
Review URL: https://codereview.chromium.org/1855733002
Diffstat (limited to 'tests')
-rw-r--r-- | tests/ImageFilterTest.cpp | 4 | ||||
-rw-r--r-- | tests/LayerRasterizerTest.cpp | 4 | ||||
-rw-r--r-- | tests/PDFPrimitivesTest.cpp | 4 | ||||
-rw-r--r-- | tests/QuickRejectTest.cpp | 2 |
4 files changed, 8 insertions, 6 deletions
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp index dda899b4f3..3f60286e39 100644 --- a/tests/ImageFilterTest.cpp +++ b/tests/ImageFilterTest.cpp @@ -219,12 +219,12 @@ private: } -SkFlattenable* MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); skiatest::Reporter* reporter = (skiatest::Reporter*)buffer.readFunctionPtr(); SkMatrix matrix; buffer.readMatrix(&matrix); - return new MatrixTestImageFilter(reporter, matrix); + return sk_make_sp<MatrixTestImageFilter>(reporter, matrix); } #ifndef SK_IGNORE_TO_STRING diff --git a/tests/LayerRasterizerTest.cpp b/tests/LayerRasterizerTest.cpp index b71c305d59..9d1fb2937a 100644 --- a/tests/LayerRasterizerTest.cpp +++ b/tests/LayerRasterizerTest.cpp @@ -43,7 +43,9 @@ private: int DummyRasterizer::gCount; -SkFlattenable* DummyRasterizer::CreateProc(SkReadBuffer&) { return new DummyRasterizer; } +sk_sp<SkFlattenable> DummyRasterizer::CreateProc(SkReadBuffer&) { + return sk_make_sp<DummyRasterizer>(); +} // Check to make sure that the SkPaint in the layer has its destructor called. DEF_TEST(LayerRasterizer_destructor, reporter) { diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp index 57b0b60b87..f4c29b358d 100644 --- a/tests/PDFPrimitivesTest.cpp +++ b/tests/PDFPrimitivesTest.cpp @@ -381,10 +381,10 @@ private: mutable bool fVisited; }; -SkFlattenable* DummyImageFilter::CreateProc(SkReadBuffer& buffer) { +sk_sp<SkFlattenable> DummyImageFilter::CreateProc(SkReadBuffer& buffer) { SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 0); bool visited = buffer.readBool(); - return new DummyImageFilter(visited); + return sk_make_sp<DummyImageFilter>(visited); } #ifndef SK_IGNORE_TO_STRING diff --git a/tests/QuickRejectTest.cpp b/tests/QuickRejectTest.cpp index 582789aa75..6a978743f6 100644 --- a/tests/QuickRejectTest.cpp +++ b/tests/QuickRejectTest.cpp @@ -49,7 +49,7 @@ private: }; }; -SkFlattenable* TestLooper::CreateProc(SkReadBuffer&) { return new TestLooper; } +sk_sp<SkFlattenable> TestLooper::CreateProc(SkReadBuffer&) { return sk_make_sp<TestLooper>(); } static void test_drawBitmap(skiatest::Reporter* reporter) { SkBitmap src; |