diff options
author | fmalita <fmalita@chromium.org> | 2015-09-15 11:26:13 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-15 11:26:14 -0700 |
commit | 5598b63cd2443a608a74a222d0206bb2455383b7 (patch) | |
tree | 1e661b0510b7deeadea831d5288989598a66a3a8 /tests | |
parent | 30c4cae7d3a26252e7e45adf6e5722b34adf6848 (diff) |
Convert unit tests, GMs from SkBitmapSource to SkImagesource
This removes SkBitmapSource clients within Skia.
http://crrev.com/1334173004 does the same for Blink, so we should be
able to remove SkBitmapSource in a follow-up.
R=reed@google.com,robertphillips@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/1343123002
Diffstat (limited to 'tests')
-rw-r--r-- | tests/ImageFilterTest.cpp | 37 | ||||
-rw-r--r-- | tests/SerializationTest.cpp | 9 |
2 files changed, 26 insertions, 20 deletions
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp index 167072975f..b1a017cc52 100644 --- a/tests/ImageFilterTest.cpp +++ b/tests/ImageFilterTest.cpp @@ -7,7 +7,6 @@ #include "SkBitmap.h" #include "SkBitmapDevice.h" -#include "SkBitmapSource.h" #include "SkBlurImageFilter.h" #include "SkCanvas.h" #include "SkColorFilterImageFilter.h" @@ -17,6 +16,7 @@ #include "SkDropShadowImageFilter.h" #include "SkFlattenableSerialization.h" #include "SkGradientShader.h" +#include "SkImage.h" #include "SkImageSource.h" #include "SkLightingImageFilter.h" #include "SkMatrixConvolutionImageFilter.h" @@ -92,10 +92,10 @@ void MatrixTestImageFilter::toString(SkString* str) const { } #endif -static void make_small_bitmap(SkBitmap& bitmap) { - bitmap.allocN32Pixels(kBitmapSize, kBitmapSize); - SkCanvas canvas(bitmap); - canvas.clear(0x00000000); +static SkImage* make_small_image() { + SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(kBitmapSize, kBitmapSize)); + SkCanvas* canvas = surface->getCanvas(); + canvas->clear(0x00000000); SkPaint darkPaint; darkPaint.setColor(0xFF804020); SkPaint lightPaint; @@ -103,26 +103,28 @@ static void make_small_bitmap(SkBitmap& bitmap) { const int i = kBitmapSize / 4; for (int y = 0; y < kBitmapSize; y += i) { for (int x = 0; x < kBitmapSize; x += i) { - canvas.save(); - canvas.translate(SkIntToScalar(x), SkIntToScalar(y)); - canvas.drawRect(SkRect::MakeXYWH(0, 0, + canvas->save(); + canvas->translate(SkIntToScalar(x), SkIntToScalar(y)); + canvas->drawRect(SkRect::MakeXYWH(0, 0, SkIntToScalar(i), SkIntToScalar(i)), darkPaint); - canvas.drawRect(SkRect::MakeXYWH(SkIntToScalar(i), + canvas->drawRect(SkRect::MakeXYWH(SkIntToScalar(i), 0, SkIntToScalar(i), SkIntToScalar(i)), lightPaint); - canvas.drawRect(SkRect::MakeXYWH(0, + canvas->drawRect(SkRect::MakeXYWH(0, SkIntToScalar(i), SkIntToScalar(i), SkIntToScalar(i)), lightPaint); - canvas.drawRect(SkRect::MakeXYWH(SkIntToScalar(i), + canvas->drawRect(SkRect::MakeXYWH(SkIntToScalar(i), SkIntToScalar(i), SkIntToScalar(i), SkIntToScalar(i)), darkPaint); - canvas.restore(); + canvas->restore(); } } + + return surface->newImageSnapshot(); } static SkImageFilter* make_scale(float amount, SkImageFilter* input = nullptr) { @@ -241,8 +243,8 @@ DEF_TEST(ImageFilter, reporter) { { // Tests pass by not asserting - SkBitmap bitmap, result; - make_small_bitmap(bitmap); + SkAutoTUnref<SkImage> image(make_small_image()); + SkBitmap result; result.allocN32Pixels(kBitmapSize, kBitmapSize); { @@ -254,7 +256,7 @@ DEF_TEST(ImageFilter, reporter) { // 3 ) large negative specular exponent value SkScalar specularExponent = -1000; - SkAutoTUnref<SkImageFilter> bmSrc(SkBitmapSource::Create(bitmap)); + SkAutoTUnref<SkImageFilter> bmSrc(SkImageSource::Create(image)); SkPaint paint; paint.setImageFilter(SkLightingImageFilter::CreateSpotLitSpecular( location, target, specularExponent, 180, @@ -424,7 +426,8 @@ DEF_TEST(ImageFilterDrawTiled, reporter) { SkScalar gain = SK_Scalar1, bias = 0; SkScalar five = SkIntToScalar(5); - SkAutoTUnref<SkImageFilter> gradient_source(SkBitmapSource::Create(make_gradient_circle(64, 64))); + SkAutoTUnref<SkImage> gradientImage(SkImage::NewFromBitmap(make_gradient_circle(64, 64))); + SkAutoTUnref<SkImageFilter> gradientSource(SkImageSource::Create(gradientImage)); SkAutoTUnref<SkImageFilter> blur(SkBlurImageFilter::Create(five, five)); SkMatrix matrix; @@ -458,7 +461,7 @@ DEF_TEST(ImageFilterDrawTiled, reporter) { { "displacement map", SkDisplacementMapEffect::Create( SkDisplacementMapEffect::kR_ChannelSelectorType, SkDisplacementMapEffect::kB_ChannelSelectorType, - 20.0f, gradient_source.get()) }, + 20.0f, gradientSource.get()) }, { "blur", SkBlurImageFilter::Create(SK_Scalar1, SK_Scalar1) }, { "drop shadow", SkDropShadowImageFilter::Create( SK_Scalar1, SK_Scalar1, SK_Scalar1, SK_Scalar1, SK_ColorGREEN, diff --git a/tests/SerializationTest.cpp b/tests/SerializationTest.cpp index 01e90d898b..38e84bd4b4 100644 --- a/tests/SerializationTest.cpp +++ b/tests/SerializationTest.cpp @@ -6,10 +6,11 @@ */ #include "Resources.h" -#include "SkBitmapSource.h" #include "SkCanvas.h" #include "SkFixed.h" #include "SkFontDescriptor.h" +#include "SkImage.h" +#include "SkImageSource.h" #include "SkMallocPixelRef.h" #include "SkOSFile.h" #include "SkPictureRecorder.h" @@ -240,8 +241,10 @@ static void TestBitmapSerialization(const SkBitmap& validBitmap, const SkBitmap& invalidBitmap, bool shouldSucceed, skiatest::Reporter* reporter) { - SkAutoTUnref<SkBitmapSource> validBitmapSource(SkBitmapSource::Create(validBitmap)); - SkAutoTUnref<SkBitmapSource> invalidBitmapSource(SkBitmapSource::Create(invalidBitmap)); + SkAutoTUnref<SkImage> validImage(SkImage::NewFromBitmap(validBitmap)); + SkAutoTUnref<SkImageFilter> validBitmapSource(SkImageSource::Create(validImage)); + SkAutoTUnref<SkImage> invalidImage(SkImage::NewFromBitmap(invalidBitmap)); + SkAutoTUnref<SkImageFilter> invalidBitmapSource(SkImageSource::Create(invalidImage)); SkAutoTUnref<SkXfermode> mode(SkXfermode::Create(SkXfermode::kSrcOver_Mode)); SkAutoTUnref<SkXfermodeImageFilter> xfermodeImageFilter( SkXfermodeImageFilter::Create(mode, invalidBitmapSource, validBitmapSource)); |