diff options
author | Cary Clark <caryclark@skia.org> | 2018-05-18 10:02:02 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-05-20 21:16:37 +0000 |
commit | 5191880cbf3ee4d122b0d11b4945fbab0784fda7 (patch) | |
tree | 28e92ae3716316b3b8d9ad8cfe47cffdadcb3ae1 /tests | |
parent | 78a764860bddd4ac8a18db87aaf21fb00a636166 (diff) |
remove toString
toString may have been used by obsolete debugger only
find out if that is so
R=brianosman@google.com,bsalomon@google.com
Docs-Preview: https://skia.org/?cl=119894
Bug:830651
Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
Reviewed-on: https://skia-review.googlesource.com/119894
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/CanvasTest.cpp | 5 | ||||
-rw-r--r-- | tests/GrShapeTest.cpp | 5 | ||||
-rw-r--r-- | tests/ImageFilterTest.cpp | 15 | ||||
-rw-r--r-- | tests/PDFPrimitivesTest.cpp | 6 | ||||
-rw-r--r-- | tests/QuickRejectTest.cpp | 4 |
5 files changed, 0 insertions, 35 deletions
diff --git a/tests/CanvasTest.cpp b/tests/CanvasTest.cpp index aee1d405be..e809dfb114 100644 --- a/tests/CanvasTest.cpp +++ b/tests/CanvasTest.cpp @@ -838,7 +838,6 @@ class ZeroBoundsImageFilter : public SkImageFilter { public: static sk_sp<SkImageFilter> Make() { return sk_sp<SkImageFilter>(new ZeroBoundsImageFilter); } - void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(ZeroBoundsImageFilter) protected: @@ -862,10 +861,6 @@ sk_sp<SkFlattenable> ZeroBoundsImageFilter::CreateProc(SkReadBuffer& buffer) { return nullptr; } -void ZeroBoundsImageFilter::toString(SkString* str) const { - str->appendf("ZeroBoundsImageFilter: ()"); -} - } // anonymous namespace DEF_TEST(Canvas_SaveLayerWithNullBoundsAndZeroBoundsImageFilter, r) { diff --git a/tests/GrShapeTest.cpp b/tests/GrShapeTest.cpp index a53dad8517..1481139e1d 100644 --- a/tests/GrShapeTest.cpp +++ b/tests/GrShapeTest.cpp @@ -1162,7 +1162,6 @@ void test_path_effect_makes_rrect(skiatest::Reporter* reporter, const Geo& geo) } static sk_sp<SkPathEffect> Make() { return sk_sp<SkPathEffect>(new RRectPathEffect); } Factory getFactory() const override { return nullptr; } - void toString(SkString*) const override {} private: RRectPathEffect() {} }; @@ -1245,7 +1244,6 @@ void test_unknown_path_effect(skiatest::Reporter* reporter, const Geo& geo) { } static sk_sp<SkPathEffect> Make() { return sk_sp<SkPathEffect>(new AddLineTosPathEffect); } Factory getFactory() const override { return nullptr; } - void toString(SkString*) const override {} private: AddLineTosPathEffect() {} }; @@ -1282,7 +1280,6 @@ void test_make_hairline_path_effect(skiatest::Reporter* reporter, const Geo& geo return sk_sp<SkPathEffect>(new MakeHairlinePathEffect); } Factory getFactory() const override { return nullptr; } - void toString(SkString*) const override {} private: MakeHairlinePathEffect() {} }; @@ -1368,7 +1365,6 @@ void test_path_effect_makes_empty_shape(skiatest::Reporter* reporter, const Geo& return sk_sp<SkPathEffect>(new EmptyPathEffect(invert)); } Factory getFactory() const override { return nullptr; } - void toString(SkString*) const override {} private: bool fInvert; EmptyPathEffect(bool invert) : fInvert(invert) {} @@ -1449,7 +1445,6 @@ void test_path_effect_fails(skiatest::Reporter* reporter, const Geo& geo) { } static sk_sp<SkPathEffect> Make() { return sk_sp<SkPathEffect>(new FailurePathEffect); } Factory getFactory() const override { return nullptr; } - void toString(SkString*) const override {} private: FailurePathEffect() {} }; diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp index 8e46715fbb..b57af7f30b 100644 --- a/tests/ImageFilterTest.cpp +++ b/tests/ImageFilterTest.cpp @@ -59,7 +59,6 @@ public: return sk_sp<SkImageFilter>(new MatrixTestImageFilter(reporter, expectedMatrix)); } - void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(MatrixTestImageFilter) protected: @@ -103,7 +102,6 @@ public: return nullptr; } - void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(FailImageFilter) private: @@ -115,11 +113,6 @@ sk_sp<SkFlattenable> FailImageFilter::CreateProc(SkReadBuffer& buffer) { return sk_sp<SkFlattenable>(new FailImageFilter()); } -void FailImageFilter::toString(SkString* str) const { - str->appendf("FailImageFilter: ("); - str->append(")"); -} - void draw_gradient_circle(SkCanvas* canvas, int width, int height) { SkScalar x = SkIntToScalar(width / 2); SkScalar y = SkIntToScalar(height / 2); @@ -297,7 +290,6 @@ public: : SkImageFilter(nullptr, 0, nullptr), fBounds(bounds) {} private: - void toString(SkString*) const override {} Factory getFactory() const override { return nullptr; } sk_sp<SkSpecialImage> onFilterImage(SkSpecialImage* src, const Context&, @@ -320,11 +312,6 @@ sk_sp<SkFlattenable> MatrixTestImageFilter::CreateProc(SkReadBuffer& buffer) { return nullptr; } -void MatrixTestImageFilter::toString(SkString* str) const { - str->appendf("MatrixTestImageFilter: ("); - str->append(")"); -} - static sk_sp<SkImage> make_small_image() { auto surface(SkSurface::MakeRasterN32Premul(kBitmapSize, kBitmapSize)); SkCanvas* canvas = surface->getCanvas(); @@ -1876,8 +1863,6 @@ DEF_TEST(ImageFilterColorSpaceDAG, reporter) { public: TestFilter() : INHERITED(nullptr, 0, nullptr) {} - void toString(SkString*) const override {} - Factory getFactory() const override { return nullptr; } size_t cloneCount() const { return fCloneCount; } diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp index b9f8a05a80..d25adea16f 100644 --- a/tests/PDFPrimitivesTest.cpp +++ b/tests/PDFPrimitivesTest.cpp @@ -357,7 +357,6 @@ public: return sk_sp<DummyImageFilter>(new DummyImageFilter(visited)); } - void toString(SkString* str) const override; SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(DummyImageFilter) bool visited() const { return fVisited; } @@ -386,11 +385,6 @@ sk_sp<SkFlattenable> DummyImageFilter::CreateProc(SkReadBuffer& buffer) { return DummyImageFilter::Make(visited); } -void DummyImageFilter::toString(SkString* str) const { - str->appendf("DummyImageFilter: ("); - str->append(")"); -} - }; // Check that PDF rendering of image filters successfully falls back to diff --git a/tests/QuickRejectTest.cpp b/tests/QuickRejectTest.cpp index 103a31d936..42e145b3bc 100644 --- a/tests/QuickRejectTest.cpp +++ b/tests/QuickRejectTest.cpp @@ -29,10 +29,6 @@ public: return nullptr; } - void toString(SkString* str) const override { - str->append("TestLooper:"); - } - SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(TestLooper) private: |