aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests
diff options
context:
space:
mode:
authorGravatar bungeman <bungeman@google.com>2014-11-04 10:54:31 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2014-11-04 10:54:32 -0800
commit4b86bacb0428b07cba01fd46452d5c46e6f21af0 (patch)
treeb273459e0f50bec0fc419f15846988a43aee4c24 /tests
parent47eda52e8fb88f0725b401762a3e0bddc98e9fb3 (diff)
Allow all font weights on Android and respect overrides.
This removes the code which forces 400 and 700 weights only, and also overrides the font weight with the configured weight. Review URL: https://codereview.chromium.org/694533006
Diffstat (limited to 'tests')
-rw-r--r--tests/FontConfigParser.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/tests/FontConfigParser.cpp b/tests/FontConfigParser.cpp
index 86b2b1db90..4273b5eeab 100644
--- a/tests/FontConfigParser.cpp
+++ b/tests/FontConfigParser.cpp
@@ -19,13 +19,12 @@ int CountFallbacks(SkTDArray<FontFamily*> fontFamilies) {
return countOfFallbackFonts;
}
-void ValidateLoadedFonts(SkTDArray<FontFamily*> fontFamilies,
+void ValidateLoadedFonts(SkTDArray<FontFamily*> fontFamilies, const char* firstExpectedFile,
skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, fontFamilies[0]->fNames.count() == 5);
REPORTER_ASSERT(reporter, !strcmp(fontFamilies[0]->fNames[0].c_str(), "sans-serif"));
REPORTER_ASSERT(reporter,
- !strcmp(fontFamilies[0]->fFonts[0].fFileName.c_str(),
- "Roboto-Regular.ttf"));
+ !strcmp(fontFamilies[0]->fFonts[0].fFileName.c_str(), firstExpectedFile));
REPORTER_ASSERT(reporter, !fontFamilies[0]->fIsFallbackFont);
}
@@ -71,7 +70,7 @@ DEF_TEST(FontConfigParserAndroid, reporter) {
REPORTER_ASSERT(reporter, CountFallbacks(preV17FontFamilies) == 10);
DumpLoadedFonts(preV17FontFamilies);
- ValidateLoadedFonts(preV17FontFamilies, reporter);
+ ValidateLoadedFonts(preV17FontFamilies, "Roboto-Regular.ttf", reporter);
} else {
resourcesMissing = true;
}
@@ -87,7 +86,7 @@ DEF_TEST(FontConfigParserAndroid, reporter) {
REPORTER_ASSERT(reporter, CountFallbacks(v17FontFamilies) == 31);
DumpLoadedFonts(v17FontFamilies);
- ValidateLoadedFonts(v17FontFamilies, reporter);
+ ValidateLoadedFonts(v17FontFamilies, "Roboto-Regular.ttf", reporter);
} else {
resourcesMissing = true;
}
@@ -103,7 +102,7 @@ DEF_TEST(FontConfigParserAndroid, reporter) {
REPORTER_ASSERT(reporter, CountFallbacks(v22FontFamilies) == 42);
DumpLoadedFonts(v22FontFamilies);
- ValidateLoadedFonts(v22FontFamilies, reporter);
+ ValidateLoadedFonts(v22FontFamilies, "Roboto-Thin.ttf", reporter);
} else {
resourcesMissing = true;
}