diff options
author | cdalton <cdalton@nvidia.com> | 2015-05-22 14:04:37 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-22 14:04:37 -0700 |
commit | 3e2d59ef36e1b9a63e524cf1b27d5f7bcfb5ff0b (patch) | |
tree | 641636014edef293ac894052c95ee955678f9512 /tests | |
parent | 682c269a1511200322916af83053e26004c0ec40 (diff) |
Fix LCD coverage regression in GrPorterDuffXPFactory
Fixes GrPorterDuffXPFactory to not use the blend table when getting
info about the LCD coverage XP.
BUG=skia:
Review URL: https://codereview.chromium.org/1149883004
Diffstat (limited to 'tests')
-rw-r--r-- | tests/GrPorterDuffTest.cpp | 56 |
1 files changed, 56 insertions, 0 deletions
diff --git a/tests/GrPorterDuffTest.cpp b/tests/GrPorterDuffTest.cpp index 79cee71333..b01277c854 100644 --- a/tests/GrPorterDuffTest.cpp +++ b/tests/GrPorterDuffTest.cpp @@ -10,6 +10,7 @@ #if SK_SUPPORT_GPU +#include "GrBatch.h" #include "GrContextFactory.h" #include "GrGpu.h" #include "GrXferProcessor.h" @@ -23,6 +24,7 @@ static void test_alpha_opaque_with_coverage(skiatest::Reporter* reporter, const static void test_alpha_opaque_no_coverage(skiatest::Reporter* reporter, const GrCaps& caps); static void test_color_white_with_coverage(skiatest::Reporter* reporter, const GrCaps& caps); static void test_color_white_no_coverage(skiatest::Reporter* reporter, const GrCaps& caps); +static void test_lcd_coverage(skiatest::Reporter* reporter, const GrCaps& caps); DEF_GPUTEST(GrPorterDuff, reporter, factory) { GrContext* ctx = factory->get(GrContextFactory::kNull_GLContextType); @@ -44,6 +46,7 @@ DEF_GPUTEST(GrPorterDuff, reporter, factory) { test_color_white_with_coverage(reporter, caps); test_color_white_with_coverage(reporter, caps); test_color_white_no_coverage(reporter, caps); + test_lcd_coverage(reporter, caps); } //////////////////////////////////////////////////////////////////////////////// @@ -100,6 +103,7 @@ static void test_alpha_unknown_with_coverage(skiatest::Reporter* reporter, const SkASSERT(!colorPOI.isOpaque()); SkASSERT(!colorPOI.isSolidWhite()); SkASSERT(!covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -290,6 +294,7 @@ static void test_alpha_unknown_no_coverage(skiatest::Reporter* reporter, const G SkASSERT(!colorPOI.isOpaque()); SkASSERT(!colorPOI.isSolidWhite()); SkASSERT(covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -491,6 +496,7 @@ static void test_alpha_opaque_with_coverage(skiatest::Reporter* reporter, const SkASSERT(colorPOI.isOpaque()); SkASSERT(!colorPOI.isSolidWhite()); SkASSERT(!covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -684,6 +690,7 @@ static void test_alpha_opaque_no_coverage(skiatest::Reporter* reporter, const Gr SkASSERT(colorPOI.isOpaque()); SkASSERT(!colorPOI.isSolidWhite()); SkASSERT(covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -890,6 +897,7 @@ static void test_color_white_with_coverage(skiatest::Reporter* reporter, const G SkASSERT(colorPOI.isOpaque()); SkASSERT(colorPOI.isSolidWhite()); SkASSERT(!covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -1082,6 +1090,7 @@ static void test_color_white_no_coverage(skiatest::Reporter* reporter, const GrC SkASSERT(colorPOI.isOpaque()); SkASSERT(colorPOI.isSolidWhite()); SkASSERT(covPOI.isSolidWhite()); + SkASSERT(!covPOI.isFourChannelOutput()); for (int m = 0; m <= SkXfermode::kLastCoeffMode; m++) { SkXfermode::Mode xfermode = static_cast<SkXfermode::Mode>(m); @@ -1276,5 +1285,52 @@ static void test_color_white_no_coverage(skiatest::Reporter* reporter, const GrC } } +static void test_lcd_coverage(skiatest::Reporter* reporter, const GrCaps& caps) { + class : public GrBatch { + void getInvariantOutputColor(GrInitInvariantOutput* out) const override { + out->setKnownFourComponents(GrColorPackRGBA(123, 45, 67, 221)); + } + + void getInvariantOutputCoverage(GrInitInvariantOutput* out) const override { + out->setUnknownFourComponents(); + out->setUsingLCDCoverage(); + } + + const char* name() const override { return "Test LCD Text Batch"; } + void initBatchTracker(const GrPipelineInfo&) override {} + bool onCombineIfPossible(GrBatch*) override { return false; } + void generateGeometry(GrBatchTarget*, const GrPipeline*) override {} + + } testLCDCoverageBatch; + + GrProcOptInfo colorPOI, covPOI; + colorPOI.calcColorWithBatch(&testLCDCoverageBatch, NULL, 0); + covPOI.calcCoverageWithBatch(&testLCDCoverageBatch, NULL, 0); + + SkASSERT(kRGBA_GrColorComponentFlags == colorPOI.validFlags()); + SkASSERT(covPOI.isFourChannelOutput()); + + SkAutoTUnref<GrXPFactory> xpf(GrPorterDuffXPFactory::Create(SkXfermode::kSrcOver_Mode)); + TEST_ASSERT(!xpf->willNeedDstCopy(caps, colorPOI, covPOI)); + + GrXPFactory::InvariantOutput invariantOutput; + xpf->getInvariantOutput(colorPOI, covPOI, &invariantOutput); + TEST_ASSERT(invariantOutput.fWillBlendWithDst); + TEST_ASSERT(kNone_GrColorComponentFlags == invariantOutput.fBlendedColorFlags); + + SkAutoTUnref<GrXferProcessor> xp(xpf->createXferProcessor(colorPOI, covPOI, 0, caps)); + if (!xp) { + ERRORF(reporter, "Failed to create an XP with LCD coverage."); + return; + } + + GrColor overrideColor; + xp->getOptimizations(colorPOI, covPOI, false, &overrideColor, caps); + + GrXferProcessor::BlendInfo blendInfo; + xp->getBlendInfo(&blendInfo); + TEST_ASSERT(blendInfo.fWriteColor); +} + #endif |