diff options
| author |  reed <reed@google.com> | 2015-09-16 13:18:41 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-09-16 13:18:41 -0700 |
| commit | 2fd18f2cd0ac307bfa6f6c50b21a8b0027385769 (patch) | |
| tree | 1f972e983694bb2fd09be30cb120349a77fc4356 /tests | |
| parent | 746f31f18037c12f9fb79fbfb0cc0bbafc204484 (diff) | |
disable test for all quality levels, since it is driver dependent
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/1352543003
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/ReadPixelsTest.cpp | 25 |
1 files changed, 14 insertions, 11 deletions
diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp index 5076a614f4..b5f84170bc 100644 --- a/tests/ReadPixelsTest.cpp +++ b/tests/ReadPixelsTest.cpp @@ -596,18 +596,21 @@ DEF_GPUTEST(ReadPixels_Subset_Gpu, reporter, factory) { SkAutoTUnref<SkSurface> surfA(SkSurface::NewRenderTarget(ctx, SkSurface::kNo_Budgeted, info, 0)); SkAutoTUnref<SkSurface> surfB(SkSurface::NewRenderTarget(ctx, SkSurface::kNo_Budgeted, info, 0)); - // - // BUG: if we change this to kNone_SkFilterQuality or kHigh_SkFilterQuality, it fails - // - SkFilterQuality quality = kLow_SkFilterQuality; - - SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality)); - SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality)); - - REPORTER_ASSERT(reporter, dataA->equals(dataB)); if (false) { - dump_to_file("test_image_A.png", dataA); - dump_to_file("test_image_B.png", dataB); + // + // BUG: depending on the driver, if we calls this with various quality settings, it + // may fail. + // + SkFilterQuality quality = kLow_SkFilterQuality; + + SkAutoTUnref<SkData> dataA(draw_into_surface(surfA, bm_subset, quality)); + SkAutoTUnref<SkData> dataB(draw_into_surface(surfB, tx_subset, quality)); + + REPORTER_ASSERT(reporter, dataA->equals(dataB)); + if (false) { + dump_to_file("test_image_A.png", dataA); + dump_to_file("test_image_B.png", dataB); + } } } #endif |