diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-07-24 18:45:27 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-07-24 18:45:27 +0000 |
| commit | cae5d8d5705081cb4d22af7a30be0f01bffce745 (patch) | |
| tree | a1a008a6f2a4cc347f4c50b1a2d6538d714c0949 /tests/Writer32Test.cpp | |
| parent | 588f3d3896ce84a00ba0b229a4fe8fff2bf67516 (diff) | |
Start from scratch on a faster SkFlatDictionary.
This is like codereview.chromium.org/19276003, except it fits in better with the existing code, doesn't leak memory, and because it's back using SkChunkFlatController it's a little faster too, now a win across the board:
Slowdown bench
-1.59% desk_youtubetvbrowse.skp
-2.56% desk_googlehome.skp
-6.40% tabl_androidpolice.skp
-6.45% desk_youtubetvvideo.skp
-6.91% tabl_googlecalendar.skp
...
-29.70% desk_yahoogames.skp
-32.17% desk_googlespreadsheet.skp
-32.23% mobi_wikipedia.skp
-37.16% desk_chalkboard.skp
-41.57% desk_pokemonwiki.skp
Overall slowdown: -22.74%
running bench [640 480] picture_record_recurring_paint_dictionary NONRENDERING: cmsecs = 9.92
running bench [640 480] picture_record_unique_paint_dictionary NONRENDERING: cmsecs = 22.16
running bench [640 480] picture_record_dictionaries NONRENDERING: cmsecs = 9.18
BUG=
R=tomhudson@google.com, reed@google.com, scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/19564007
git-svn-id: http://skia.googlecode.com/svn/trunk@10328 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/Writer32Test.cpp')
| -rw-r--r-- | tests/Writer32Test.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/tests/Writer32Test.cpp b/tests/Writer32Test.cpp index 498be9cb81..e5b93634ac 100644 --- a/tests/Writer32Test.cpp +++ b/tests/Writer32Test.cpp @@ -187,18 +187,23 @@ static void Tests(skiatest::Reporter* reporter) { SkWriter32 writer(0); uint32_t storage[256]; writer.reset(storage, sizeof(storage)); + // These three writes are small enough to fit in storage. test1(reporter, &writer); + REPORTER_ASSERT(reporter, writer.wroteOnlyToStorage()); writer.reset(storage, sizeof(storage)); test2(reporter, &writer); + REPORTER_ASSERT(reporter, writer.wroteOnlyToStorage()); writer.reset(storage, sizeof(storage)); testWritePad(reporter, &writer); + REPORTER_ASSERT(reporter, writer.wroteOnlyToStorage()); - // try overflowing the storage-block + // Try overflowing the storage-block. uint32_t smallStorage[8]; writer.reset(smallStorage, sizeof(smallStorage)); test2(reporter, &writer); + REPORTER_ASSERT(reporter, !writer.wroteOnlyToStorage()); } // small storage |