aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/SkSLErrorTest.cpp
diff options
context:
space:
mode:
authorGravatar ethannicholas <ethannicholas@google.com>2016-10-28 09:02:46 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-10-28 09:02:46 -0700
commit471e89405b71f04e07ae2887bde061185e262c81 (patch)
treeb8fbded8db37f07ea9750ce317ef12f336dd414a /tests/SkSLErrorTest.cpp
parent55e0346f4ba923ae1a4cc2f3754ee4a682578bcc (diff)
Reduced skslc memory consumption
The big change here is smarter generic type handling which allows us to keep far fewer entries in the core symboltable. This also comments out a number of OpenGL builtin functions which Skia does not use and is unlikely to in the future. BUG=655673 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2442063002 Committed: https://skia.googlesource.com/skia/+/cffaa70896fa5bc6c7bf98abbaafb1a755b49762 Review-Url: https://codereview.chromium.org/2442063002
Diffstat (limited to 'tests/SkSLErrorTest.cpp')
-rw-r--r--tests/SkSLErrorTest.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/tests/SkSLErrorTest.cpp b/tests/SkSLErrorTest.cpp
index 47e31e6ee4..3afb64fe61 100644
--- a/tests/SkSLErrorTest.cpp
+++ b/tests/SkSLErrorTest.cpp
@@ -43,7 +43,12 @@ DEF_TEST(SkSLUndefinedFunction, r) {
DEF_TEST(SkSLGenericArgumentMismatch, r) {
test_failure(r,
"void main() { float x = sin(1, 2); }",
- "error: 1: no match for sin(int, int)\n1 error\n");
+ "error: 1: call to 'sin' expected 1 argument, but found 2\n1 error\n");
+ test_failure(r,
+ "void main() { float x = sin(true); }",
+ "error: 1: no match for sin(bool)\n1 error\n");
+ test_success(r,
+ "void main() { float x = sin(1); }");
}
DEF_TEST(SkSLArgumentCountMismatch, r) {