aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/SkResourceCacheTest.cpp
diff options
context:
space:
mode:
authorGravatar reed <reed@google.com>2015-09-17 13:27:44 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-09-17 13:27:44 -0700
commit2ed7d50307d2c059b1c0a94747b3e1b9d49491e7 (patch)
tree5a6b0b26ae629d3b18e3806142fb4d7f5755f95f /tests/SkResourceCacheTest.cpp
parenteb44d53cf96a7eaf103a98d76079ce1f5495e343 (diff)
remove racy tests, as they assume the cache can't be purged behind their back
If I explicitly purge the resource-cache after every DM, these tests fail (sporadically) . BUG=skia: Review URL: https://codereview.chromium.org/1350143002
Diffstat (limited to 'tests/SkResourceCacheTest.cpp')
-rw-r--r--tests/SkResourceCacheTest.cpp67
1 files changed, 0 insertions, 67 deletions
diff --git a/tests/SkResourceCacheTest.cpp b/tests/SkResourceCacheTest.cpp
index 9df15192d8..4432b87d3b 100644
--- a/tests/SkResourceCacheTest.cpp
+++ b/tests/SkResourceCacheTest.cpp
@@ -13,72 +13,6 @@
#include "SkResourceCache.h"
#include "SkSurface.h"
-static const int kCanvasSize = 1;
-static const int kBitmapSize = 16;
-static const int kScale = 8;
-
-static bool is_in_scaled_image_cache(const SkBitmap& orig,
- SkScalar xScale,
- SkScalar yScale) {
- SkBitmap scaled;
- int width = SkScalarRoundToInt(orig.width() * xScale);
- int height = SkScalarRoundToInt(orig.height() * yScale);
- return SkBitmapCache::FindWH(SkBitmapCacheDesc::Make(orig, width, height), &scaled);
-}
-
-// Draw a scaled bitmap, then return true if it has been cached.
-static bool test_scaled_image_cache_usage() {
- SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(kCanvasSize, kCanvasSize));
- SkCanvas* canvas = surface->getCanvas();
- SkBitmap bitmap;
- bitmap.allocN32Pixels(kBitmapSize, kBitmapSize);
- bitmap.eraseColor(0xFFFFFFFF);
- SkScalar xScale = SkIntToScalar(kScale);
- SkScalar yScale = xScale / 2;
- SkScalar xScaledSize = SkIntToScalar(kBitmapSize) * xScale;
- SkScalar yScaledSize = SkIntToScalar(kBitmapSize) * yScale;
- canvas->clipRect(SkRect::MakeLTRB(0, 0, xScaledSize, yScaledSize));
- SkPaint paint;
- paint.setFilterQuality(kHigh_SkFilterQuality);
-
- canvas->drawBitmapRect(bitmap,
- SkRect::MakeLTRB(0, 0, xScaledSize, yScaledSize),
- &paint);
-
- return is_in_scaled_image_cache(bitmap, xScale, yScale);
-}
-
-// http://crbug.com/389439
-DEF_TEST(ResourceCache_SingleAllocationByteLimit, reporter) {
- size_t originalByteLimit = SkGraphics::GetResourceCacheTotalByteLimit();
- size_t originalAllocationLimit =
- SkGraphics::GetResourceCacheSingleAllocationByteLimit();
-
- size_t size = kBitmapSize * kScale * kBitmapSize * kScale
- * SkColorTypeBytesPerPixel(kN32_SkColorType);
-
- SkGraphics::SetResourceCacheTotalByteLimit(0); // clear cache
- SkGraphics::SetResourceCacheTotalByteLimit(2 * size);
- SkGraphics::SetResourceCacheSingleAllocationByteLimit(0); // No limit
-
- REPORTER_ASSERT(reporter, test_scaled_image_cache_usage());
-
- SkGraphics::SetResourceCacheTotalByteLimit(0); // clear cache
- SkGraphics::SetResourceCacheTotalByteLimit(2 * size);
- SkGraphics::SetResourceCacheSingleAllocationByteLimit(size * 2); // big enough
-
- REPORTER_ASSERT(reporter, test_scaled_image_cache_usage());
-
- SkGraphics::SetResourceCacheTotalByteLimit(0); // clear cache
- SkGraphics::SetResourceCacheTotalByteLimit(2 * size);
- SkGraphics::SetResourceCacheSingleAllocationByteLimit(size / 2); // too small
-
- REPORTER_ASSERT(reporter, !test_scaled_image_cache_usage());
-
- SkGraphics::SetResourceCacheSingleAllocationByteLimit(originalAllocationLimit);
- SkGraphics::SetResourceCacheTotalByteLimit(originalByteLimit);
-}
-
////////////////////////////////////////////////////////////////////////////////////////
static void make_bitmap(SkBitmap* bitmap, const SkImageInfo& info, SkBitmap::Allocator* allocator) {
@@ -268,7 +202,6 @@ DEF_TEST(BitmapCache_discarded_bitmap, reporter) {
if (factory) {
REPORTER_ASSERT(reporter, SkGetGlobalDiscardableMemoryPool()->getRAMUsed() > 0);
SkGetGlobalDiscardableMemoryPool()->dumpPool();
- REPORTER_ASSERT(reporter, SkGetGlobalDiscardableMemoryPool()->getRAMUsed() == 0);
// The bitmap is not in the cache since it has been dropped.
REPORTER_ASSERT(reporter, !SkBitmapCache::Find(cachedBitmap.getGenerationID(), rect, &bm, cache));