diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-29 16:52:40 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-29 16:52:40 +0000 |
| commit | a095041f5148dd1e71f38d0546335ed94199104b (patch) | |
| tree | 63730963cc5cb4be0430263ed195b217e0341e04 /tests/RecordPatternTest.cpp | |
| parent | cac02e52cda552fc792b0035a8b03b08c33ed35d (diff) | |
Remove SkRecorder's kWriteOnly mode.
I'm soon going to have SkRecorder start calling getTotalMatrix(), which
would be broken in write-only mode. That change is big and nebulous,
but it's clear kWriteOnly needs to go, so we might as well kill it now.
My notes in bench_playback about kWriteOnly mode being important were
probably overly cautious. I now think this is a fair enough comparison
even re-recording into a read-write canvas.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/290653004
git-svn-id: http://skia.googlecode.com/svn/trunk@14963 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/RecordPatternTest.cpp')
| -rw-r--r-- | tests/RecordPatternTest.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/tests/RecordPatternTest.cpp b/tests/RecordPatternTest.cpp index b0904ab7d6..5f4d006683 100644 --- a/tests/RecordPatternTest.cpp +++ b/tests/RecordPatternTest.cpp @@ -17,7 +17,7 @@ DEF_TEST(RecordPattern_Simple, r) { SkRecord record; REPORTER_ASSERT(r, !pattern.match(&record, 0)); - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); // Build up a save-clip-restore block. The pattern will match only it's complete. recorder.save(); @@ -37,7 +37,7 @@ DEF_TEST(RecordPattern_StartingIndex, r) { SaveClipRectRestore pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); // There will be two save-clipRect-restore blocks [0,3) and [3,6). for (int i = 0; i < 2; i++) { @@ -60,7 +60,7 @@ DEF_TEST(RecordPattern_DontMatchSubsequences, r) { SaveClipRectRestore pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); recorder.save(); recorder.clipRect(SkRect::MakeWH(300, 200)); @@ -74,7 +74,7 @@ DEF_TEST(RecordPattern_Star, r) { Pattern3<Is<Save>, Star<Is<ClipRect> >, Is<Restore> > pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); recorder.save(); recorder.restore(); @@ -96,7 +96,7 @@ DEF_TEST(RecordPattern_IsDraw, r) { Pattern3<Is<Save>, IsDraw, Is<Restore> > pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); recorder.save(); recorder.clipRect(SkRect::MakeWH(300, 200)); @@ -135,7 +135,7 @@ DEF_TEST(RecordPattern_Complex, r) { Is<Restore> > pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); recorder.save(); recorder.restore(); @@ -192,7 +192,7 @@ DEF_TEST(RecordPattern_SaveLayerIsNotADraw, r) { Pattern1<IsDraw> pattern; SkRecord record; - SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, 1920, 1200); + SkRecorder recorder(&record, 1920, 1200); recorder.saveLayer(NULL, NULL); REPORTER_ASSERT(r, !pattern.match(&record, 0)); |