diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-08 18:58:32 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-08 18:58:32 +0000 |
| commit | 888e4687d96b6af5b5c0efbcf05fcdc010ea8aa2 (patch) | |
| tree | d8dbdff9243a2c57d33c550dbb20a3939538810d /tests/RecordPatternTest.cpp | |
| parent | 3d41c4add81e95784faa81f9a59b4a32b7cff082 (diff) | |
Split Star into Star (stores nothing) and List (stores matches).
Just noticed that the cull noop pattern (PushCull, Star<NoOp>, PopCull)
would trigger the Star that stores matches. We certainly don't need
those matches here, so instead of magically determining which Star you
need, we'll make you tell us which one you want.
No one but List's unit test needs List. I'll leave it for now, but we
might find it's not useful.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/275623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14655 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/RecordPatternTest.cpp')
| -rw-r--r-- | tests/RecordPatternTest.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tests/RecordPatternTest.cpp b/tests/RecordPatternTest.cpp index 4f51bdba24..b0904ab7d6 100644 --- a/tests/RecordPatternTest.cpp +++ b/tests/RecordPatternTest.cpp @@ -79,20 +79,17 @@ DEF_TEST(RecordPattern_Star, r) { recorder.save(); recorder.restore(); REPORTER_ASSERT(r, pattern.match(&record, 0)); - REPORTER_ASSERT(r, pattern.second<SkTDArray<ClipRect*> >()->count() == 0); recorder.save(); recorder.clipRect(SkRect::MakeWH(300, 200)); recorder.restore(); REPORTER_ASSERT(r, pattern.match(&record, 2)); - REPORTER_ASSERT(r, pattern.second<SkTDArray<ClipRect*> >()->count() == 1); recorder.save(); recorder.clipRect(SkRect::MakeWH(300, 200)); recorder.clipRect(SkRect::MakeWH(100, 100)); recorder.restore(); REPORTER_ASSERT(r, pattern.match(&record, 5)); - REPORTER_ASSERT(r, pattern.second<SkTDArray<ClipRect*> >()->count() == 2); } DEF_TEST(RecordPattern_IsDraw, r) { |