diff options
author | Mike Reed <reed@google.com> | 2017-04-17 10:53:29 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-04-17 15:22:42 +0000 |
commit | 12e946b4bfdf598bffb276776ea6e25439e25265 (patch) | |
tree | 3431130a5008af573c497da13243da360d147918 /tests/ReadPixelsTest.cpp | |
parent | 81340c65e0e507ca544e32c0fa0c6880f371eaff (diff) |
deprecate odd variants of SkCanvas::readPixels
Bug: skia:6513
Change-Id: I51179a85f0912d3f899c368c30a943d346dd1d05
Reviewed-on: https://skia-review.googlesource.com/13589
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'tests/ReadPixelsTest.cpp')
-rw-r--r-- | tests/ReadPixelsTest.cpp | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp index 10462c9140..697d3ee99e 100644 --- a/tests/ReadPixelsTest.cpp +++ b/tests/ReadPixelsTest.cpp @@ -247,8 +247,7 @@ static bool check_read(skiatest::Reporter* reporter, enum BitmapInit { kFirstBitmapInit = 0, - kNoPixels_BitmapInit = kFirstBitmapInit, - kTight_BitmapInit, + kTight_BitmapInit = kFirstBitmapInit, kRowBytes_BitmapInit, kRowBytesOdd_BitmapInit, @@ -270,10 +269,7 @@ static void init_bitmap(SkBitmap* bitmap, const SkIRect& rect, BitmapInit init, SkAlphaType at) { SkImageInfo info = SkImageInfo::Make(rect.width(), rect.height(), ct, at); size_t rowBytes = 0; - bool alloc = true; switch (init) { - case kNoPixels_BitmapInit: - alloc = false; case kTight_BitmapInit: break; case kRowBytes_BitmapInit: @@ -286,12 +282,7 @@ static void init_bitmap(SkBitmap* bitmap, const SkIRect& rect, BitmapInit init, SkASSERT(0); break; } - - if (alloc) { - bitmap->allocPixels(info, rowBytes); - } else { - bitmap->setInfo(info, rowBytes); - } + bitmap->allocPixels(info, rowBytes); } static const struct { @@ -370,7 +361,7 @@ static void test_readpixels(skiatest::Reporter* reporter, const sk_sp<SkSurface> fill_dst_bmp_with_init_data(&bmp); } uint32_t idBefore = surface->generationID(); - bool success = canvas->readPixels(&bmp, srcRect.fLeft, srcRect.fTop); + bool success = canvas->readPixels(bmp, srcRect.fLeft, srcRect.fTop); uint32_t idAfter = surface->generationID(); // we expect to succeed when the read isn't fully clipped @@ -391,6 +382,7 @@ static void test_readpixels(skiatest::Reporter* reporter, const sk_sp<SkSurface> REPORTER_ASSERT(reporter, bmp.isNull()); } } +#ifdef SK_SUPPORT_LEGACY_CANVAS_READPIXELS // check the old webkit version of readPixels that clips the // bitmap size SkBitmap wkbmp; @@ -406,6 +398,7 @@ static void test_readpixels(skiatest::Reporter* reporter, const sk_sp<SkSurface> } else { REPORTER_ASSERT(reporter, !success); } +#endif } } } |