aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/ProcessorTest.cpp
diff options
context:
space:
mode:
authorGravatar Greg Daniel <egdaniel@google.com>2017-12-01 16:19:43 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-12-02 00:00:59 +0000
commit10ed243e2ee7d733f73c9e5947ab5189fd6d46e3 (patch)
tree5cce27e7a9212b26532780c1a92796ca712da1bb /tests/ProcessorTest.cpp
parent0d05ca3e2fc36a8397b4cec4c23284beaf87642c (diff)
Add cap on intel to avoid calling abs and floor on the same line in a
shader. This fixes a bug on some intel devices where we are failing in the ProcessorOptimizationTest. I've tried other "no op" type things between the floor call and abs which also fixed the issue, as well as adding explicit checks to see if we are less than -1 or greater than 1 where the clamp is. Thus the clamp itself should be a no op and shouldn't secretly be fixing the problem outside of forcing the floor and abs lines to be separate. Bug: skia: Change-Id: I85bf82e0e02607b78470b7a5f8f918e9f53f0154 Reviewed-on: https://skia-review.googlesource.com/76820 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'tests/ProcessorTest.cpp')
-rw-r--r--tests/ProcessorTest.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/ProcessorTest.cpp b/tests/ProcessorTest.cpp
index 177eead450..1d393d6b79 100644
--- a/tests/ProcessorTest.cpp
+++ b/tests/ProcessorTest.cpp
@@ -434,8 +434,8 @@ DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(ProcessorOptimizationValidationTest, repor
if (!legalColorModulation && !legalAlphaModulation) {
ERRORF(reporter,
"\"Modulating\" processor %s made color/alpha value larger. "
- "Input: 0x%08x, Output: 0x%08x.",
- clone->name(), input, output);
+ "Input: 0x%08x, Output: 0x%08x, pixel (%d, %d).",
+ clone->name(), input, output, x, y);
passing = false;
}
}