diff options
| author |  Brian Salomon <bsalomon@google.com> | 2017-10-17 19:14:05 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-17 19:14:15 +0000 |
| commit | 62563deb6b4dbb0b1db7f29f35e07dcef043af31 (patch) | |
| tree | 66d808c7c81cfe96056188c4137d50a32baecce3 /tests/PrimitiveProcessorTest.cpp | |
| parent | d4faecd2dcd2de6e8ae01ccc497ba74d1f6a59b1 (diff) | |
Revert "Make GPU backend triangulate rects such that they are rendered as tri strips rather than tri fans."
This reverts commit fa2d604a7ded95a3ace905519b476129cd0fffcb.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Make GPU backend triangulate rects such that they are rendered as tri strips rather than tri fans.
>
> Right now when we turn rects into quads we use a vertex order compatible with a tri fan rather than a tri strip.
>
> I wanted it to be the case that the same code could be used to generate a non-indexed mesh for a single rect or indexed using the quad index buffer when batching. Triangle fanning is not available in all APIS (e.g. is emulated in ANGLE and not supported in Metal) so it seems better to use a triangle strip over a fan in the single rect case.
>
>
> Change-Id: I31eebd794e7328f4b39e3ec3377bf2ec556360ca
> Reviewed-on: https://skia-review.googlesource.com/60081
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
TBR=bsalomon@google.com,robertphillips@google.com
Change-Id: I7c4c23aa418da09c9708b28cce64ab58e282dd3a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/60683
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Diffstat (limited to 'tests/PrimitiveProcessorTest.cpp')
| -rw-r--r-- | tests/PrimitiveProcessorTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/PrimitiveProcessorTest.cpp b/tests/PrimitiveProcessorTest.cpp index 97dc2ac7f5..004ec88cc2 100644 --- a/tests/PrimitiveProcessorTest.cpp +++ b/tests/PrimitiveProcessorTest.cpp @@ -96,7 +96,7 @@ private: QuadHelper helper; size_t vertexStride = gp->getVertexStride(); SkPoint* vertices = reinterpret_cast<SkPoint*>(helper.init(target, vertexStride, 1)); - vertices->setRectTriStrip(0.f, 0.f, 1.f, 1.f, vertexStride); + vertices->setRectFan(0.f, 0.f, 1.f, 1.f, vertexStride); helper.recordDraw(target, gp.get(), target->makePipeline(0, GrProcessorSet::MakeEmptySet(), target->detachAppliedClip())); |