diff options
author | 2014-09-09 18:46:22 -0700 | |
---|---|---|
committer | 2014-09-09 18:46:22 -0700 | |
commit | d954498c01ccf0417feacf89e45d0c62a06a813b (patch) | |
tree | bc6676ab7fb5b44b297daf141f1bbf0dafe31f6c /tests/PictureTest.cpp | |
parent | 87a79236f53cb1e1e4be494a14142cea03b93a77 (diff) |
Revert of Revert of allow canvas to force conservative clips (for speed) (patchset #1 id:1 of https://codereview.chromium.org/554033003/)
Reason for revert:
May just rebaseline, plus want to see the results of the chrome tests, so re-trying this CL.
Original issue's description:
> Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/)
>
> Reason for revert:
> multipicturedraw failed on nvprmsaa -- don't know why yet
>
> Original issue's description:
> > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects:
> >
> > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often.
> >
> > 2. The conservative clips mean less work is done.
> >
> > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases.
> >
> > 4. API is private for now.
> >
> > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241
>
> TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11
R=robertphillips@google.com, bsalomon@google.com, mtklein@google.com, junov@google.com, reed@google.com
TBR=bsalomon@google.com, junov@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/560713002
Diffstat (limited to 'tests/PictureTest.cpp')
-rw-r--r-- | tests/PictureTest.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp index 05aec092c3..3bc91d78a7 100644 --- a/tests/PictureTest.cpp +++ b/tests/PictureTest.cpp @@ -1570,8 +1570,8 @@ static void test_clip_bound_opt(skiatest::Reporter* reporter) { path2.addOval(rect3); SkIRect clipBounds; SkPictureRecorder recorder; - // Minimalist test set for 100% code coverage of - // SkPictureRecord::updateClipConservativelyUsingBounds + + // Testing conservative-raster-clip that is enabled by PictureRecord { SkCanvas* canvas = recorder.beginRecording(10, 10); canvas->clipPath(invPath, SkRegion::kIntersect_Op); |