aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/PathOpsTSectDebug.h
diff options
context:
space:
mode:
authorGravatar Cary Clark <caryclark@skia.org>2018-03-14 15:55:02 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-03-15 17:07:16 +0000
commitb8421edb47e9b3831df64d03a00f15509c2bebaa (patch)
treec06608d81848316c8a8c1a57938a72911d99ac00 /tests/PathOpsTSectDebug.h
parentc2ec4e8d83e42d7059528e3ccc7c3ab584ed1f31 (diff)
fix pathops fuzzers and debugging
En route to fixing fuzzer bugs, I discovered that most debugging in pathops was broken. Pathops has extensive runtime functions that trace links and connections between data structures that are invaluable to debugging. The only practical way to use these functions is to call them from the debugger in immediate mode. Some time, some where, the MSVS Immediate Window ceased to be able to call functions that are members of structs or classes, and functions that take templated parameters. I can find no mention of this on the web, so I assume that something about our setup is triggering this, but I've had no luck finding the culprit. In the meantime, I've added global functions wrapped in a namespace to sneak calls to these functions without MSVS being any the wiser. While this works, it is likely to bitrot by tomorrow or next Tuesday so I will continue to try to find and fix the root cause. This also fixes the fuzzer bugs; generally one-line edits that change asserts to fails. All pathops tests succeed with this. To run all tests, do: ./out/debug/pathops_unittest -V -x ./out/release/pathops_unittest -V -x TBR=caryclark@google.com Bug: skia: Change-Id: I956ae3d8df6d25e155e62bd6dede64519c7fbdb1 Reviewed-on: https://skia-review.googlesource.com/114321 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
Diffstat (limited to 'tests/PathOpsTSectDebug.h')
-rw-r--r--tests/PathOpsTSectDebug.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/PathOpsTSectDebug.h b/tests/PathOpsTSectDebug.h
index 209152104b..7b0f19d877 100644
--- a/tests/PathOpsTSectDebug.h
+++ b/tests/PathOpsTSectDebug.h
@@ -67,7 +67,7 @@ void SkTSect<TCurve, OppCurve>::dumpBoth(SkTSect<OppCurve, TCurve>* opp) const {
SkDebugf("%d ", ++gDumpTSectNum);
#endif
this->dump();
- SkDebugf(" ");
+ SkDebugf("\n");
opp->dump();
SkDebugf("\n");
#elif DEBUG_T_SECT_DUMP == 3