diff options
| author |  caryclark <caryclark@google.com> | 2014-06-18 07:24:19 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-18 07:24:19 -0700 |
| commit | e4097e3a0b10bb0047a45b6949ca01826f0807a7 (patch) | |
| tree | 1b04df78fa4a4aa239d09184e88929102d12886a /tests/PathOpsSkpTest.cpp | |
| parent | 683e90611c8a536c3c5feedea27bbbefedf746d2 (diff) | |
Fix last pathops skp bug
This fixes the last bug discovered by iterating through the 800K
skp corpus representing the top 1M websites. For every clip on the
stack, the paths are replaced with the pathop intersection. The
resulting draw is compared with the original draw for pixel errors.
At least two prominent bugs remain. In one, the winding value is
confused by a cubic with an inflection. In the other, a quad/cubic
pair, nearly coincident, fails to find an intersection.
These minor changes include ignoring very tiny self-intersections
of cubics, and processing degenerate edges that don't connect to
anything else.
R=reed@android.com
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/340103002
Diffstat (limited to 'tests/PathOpsSkpTest.cpp')
| -rwxr-xr-x | tests/PathOpsSkpTest.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tests/PathOpsSkpTest.cpp b/tests/PathOpsSkpTest.cpp index 3cfe4e2f7a..d62e326278 100755 --- a/tests/PathOpsSkpTest.cpp +++ b/tests/PathOpsSkpTest.cpp @@ -8,8 +8,6 @@ #define TEST(name) { name, #name } -#define TRY_NEW_TESTS 0 - static void skpcheeseandburger_com225(skiatest::Reporter* reporter, const char* filename) { SkPath path; path.setFillType(SkPath::kEvenOdd_FillType); @@ -1808,7 +1806,6 @@ static void skpwww_heartiste_wordpress_com_86(skiatest::Reporter* reporter, cons testPathOp(reporter, path, pathB, kIntersect_PathOp, filename); } -#if TRY_NEW_TESTS static void skpwww_argus_presse_fr_41(skiatest::Reporter* reporter, const char* filename) { SkPath path; path.setFillType(SkPath::kEvenOdd_FillType); @@ -1827,7 +1824,6 @@ static void skpwww_argus_presse_fr_41(skiatest::Reporter* reporter, const char* pathB.close(); testPathOp(reporter, path, pathB, kIntersect_PathOp, filename); } -#endif // SkOpSegment::checkSmallCoincidence; line 1958 SkASSERT(span.fWindValue); static void skpwww_320kbps_net_2231(skiatest::Reporter* reporter, const char* filename) { @@ -3557,9 +3553,7 @@ static struct TestDesc tests[] = { TEST(skpwww_wartepop_blogspot_com_br_6), TEST(skpwww_wartepop_blogspot_com_br_6a), TEST(skpwww_cooksnaps_com_32a), -#if TRY_NEW_TESTS TEST(skpwww_argus_presse_fr_41), -#endif TEST(skpwww_cooksnaps_com_17), TEST(skpwww_cooksnaps_com_32), TEST(skpwww_kitcheninspirations_wordpress_com_66), |