diff options
| author |  caryclark <caryclark@google.com> | 2016-10-20 08:32:18 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-10-20 08:32:18 -0700 |
| commit | a35ab3e6e024d0b548ded26a2e3b8ecd838ead93 (patch) | |
| tree | c009069f86b1129fcf5037ffc8e8fbf1b9ba010f /tests/PathOpsQuadLineIntersectionTest.cpp | |
| parent | 65820db5e15201a3f30968420232d36c0ca89cd8 (diff) | |
fix fuzzers
Many old pathops-related fuzz failures have built up while
the codebase was under a state a flux. Now that the code
is stable, address these failures.
Most of the CL plumbs the debug global state to downstream
routines so that, if the data is not trusted (ala fuzzed)
the function can safely exit without asserting.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426173002
Review-Url: https://chromiumcodereview.appspot.com/2426173002
Diffstat (limited to 'tests/PathOpsQuadLineIntersectionTest.cpp')
| -rw-r--r-- | tests/PathOpsQuadLineIntersectionTest.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/tests/PathOpsQuadLineIntersectionTest.cpp b/tests/PathOpsQuadLineIntersectionTest.cpp index 6a9e497b91..f24b2e4d7a 100644 --- a/tests/PathOpsQuadLineIntersectionTest.cpp +++ b/tests/PathOpsQuadLineIntersectionTest.cpp @@ -13,7 +13,7 @@ #include "Test.h" static struct lineQuad { - SkDQuad quad; + QuadPts quad; SkDLine line; int result; SkDPoint expected[2]; @@ -56,7 +56,7 @@ static int doIntersect(SkIntersections& intersections, const SkDQuad& quad, cons } static struct oneLineQuad { - SkDQuad quad; + QuadPts quad; SkDLine line; } oneOffs[] = { {{{{97.9337616,100}, {88,112.94265}, {88,130}}}, @@ -79,7 +79,9 @@ static size_t oneOffs_count = SK_ARRAY_COUNT(oneOffs); static void testOneOffs(skiatest::Reporter* reporter) { bool flipped = false; for (size_t index = 0; index < oneOffs_count; ++index) { - const SkDQuad& quad = oneOffs[index].quad; + const QuadPts& q = oneOffs[index].quad; + SkDQuad quad; + quad.debugSet(q.fPts); SkASSERT(ValidQuad(quad)); const SkDLine& line = oneOffs[index].line; SkASSERT(ValidLine(line)); @@ -106,7 +108,9 @@ DEF_TEST(PathOpsQuadLineIntersectionOneOff, reporter) { DEF_TEST(PathOpsQuadLineIntersection, reporter) { for (size_t index = 0; index < lineQuadTests_count; ++index) { int iIndex = static_cast<int>(index); - const SkDQuad& quad = lineQuadTests[index].quad; + const QuadPts& q = lineQuadTests[index].quad; + SkDQuad quad; + quad.debugSet(q.fPts); SkASSERT(ValidQuad(quad)); const SkDLine& line = lineQuadTests[index].line; SkASSERT(ValidLine(line)); |