aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/PathOpsIssue3651.cpp
diff options
context:
space:
mode:
authorGravatar Cary Clark <caryclark@google.com>2017-01-18 11:00:57 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-01-20 17:35:30 +0000
commitd2eb581ebc8f8009e80cccccd74d5b341ef5bd5b (patch)
treeb7e839cf44743ce6d8119ad527ebaae5e2c1ea6d /tests/PathOpsIssue3651.cpp
parentf833215420847565b4c9945aebdc2e7ae182937f (diff)
offset angle check edge in common
When curves cross, their intersection points may be nearby, but not exactly the same. Sort the angles formed by the crossing curves when all angles don't have the same origin. This sets up the framework to solve test case that currently fail (e.g., joel6) but does not fix all related test cases (e.g., joel9). All older existing test cases, including extended tests, pass. Rework the test framework to better report when tests expected to produce failing results now pass. Add new point and vector operations to support offset angles. TBR=reed@google.com BUG=skia:6041 Change-Id: I67c651ded0a25e99ad93d55d6a35109b3ee3698e Reviewed-on: https://skia-review.googlesource.com/6624 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
Diffstat (limited to 'tests/PathOpsIssue3651.cpp')
-rw-r--r--tests/PathOpsIssue3651.cpp8
1 files changed, 2 insertions, 6 deletions
diff --git a/tests/PathOpsIssue3651.cpp b/tests/PathOpsIssue3651.cpp
index bd4ed2d9ab..dc93657d08 100644
--- a/tests/PathOpsIssue3651.cpp
+++ b/tests/PathOpsIssue3651.cpp
@@ -472,9 +472,7 @@ path.close();
static void issue3651_1a(skiatest::Reporter* reporter, const char* filename) {
SkPath path = path1_a();
SkPath pathB = path2_a();
- // DEBUG_UNDER_DEVELOPMENT issue3651_1a disable expectation check for now
- testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename,
- !SkOpGlobalState::DebugRunFail());
+ testPathOpTry(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename);
}
static SkPath path3() {
@@ -1204,9 +1202,7 @@ path.close();
static void issue3651_1(skiatest::Reporter* reporter, const char* filename) {
SkPath path = path1();
SkPath pathB = path2();
- // DEBUG_UNDER_DEVELOPMENT issue3651_1 disable expectation check for now
- testPathOpCheck(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename,
- !SkOpGlobalState::DebugRunFail());
+ testPathOpTry(reporter, path, pathB, SkPathOp::kUnion_SkPathOp, filename);
}
static void issue3651_2(skiatest::Reporter* reporter, const char* filename) {