aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/PathOpsDVectorTest.cpp
diff options
context:
space:
mode:
authorGravatar caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-07-16 16:11:16 +0000
committerGravatar caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-07-16 16:11:16 +0000
commit8d0a524a4847bc7e1cc63a93b78922739466c201 (patch)
treeaf95f937257448db5658c8b658c53775debbbd5b /tests/PathOpsDVectorTest.cpp
parent92fe073efbd9287cdb4d01a1b9c0664fc5d4fdd0 (diff)
harden and speed up path op unit tests
PathOps tests internal routines direcctly. Check to make sure that test points, lines, quads, curves, triangles, and bounds read from arrays are valid (i.e., don't contain NaN) before calling the test function. Repurpose the test flags. - make 'v' verbose test region output against path output - make 'z' single threaded (before it made it multithreaded) The latter change speeds up tests run by the buildbot by 2x to 3x. BUG= Review URL: https://codereview.chromium.org/19374003 git-svn-id: http://skia.googlecode.com/svn/trunk@10107 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/PathOpsDVectorTest.cpp')
-rw-r--r--tests/PathOpsDVectorTest.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/PathOpsDVectorTest.cpp b/tests/PathOpsDVectorTest.cpp
index 6d752c5388..23ca2a8186 100644
--- a/tests/PathOpsDVectorTest.cpp
+++ b/tests/PathOpsDVectorTest.cpp
@@ -4,6 +4,7 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
+#include "PathOpsTestCommon.h"
#include "SkPathOpsPoint.h"
#include "Test.h"
@@ -22,7 +23,9 @@ static const size_t tests_count = SK_ARRAY_COUNT(tests);
static void PathOpsDVectorTest(skiatest::Reporter* reporter) {
for (size_t index = 0; index < tests_count - 1; ++index) {
SkDVector v1 = tests[index + 1] - tests[index];
+ SkASSERT(ValidVector(v1));
SkDVector v2 = tests[index] - tests[index + 1];
+ SkASSERT(ValidVector(v2));
v1 += v2;
REPORTER_ASSERT(reporter, v1.fX == 0 && v1.fY == 0);
SkDPoint p = tests[index + 1] + v2;