diff options
| author |  mtklein <mtklein@chromium.org> | 2016-01-04 19:13:19 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-01-04 19:13:19 -0800 |
| commit | 279c7864090a7b96c34c3594e38ced35967c673f (patch) | |
| tree | 3ecd209f1ca5798f6b3d491f9bcd683609b8ca52 /tests/OnceTest.cpp | |
| parent | c4a0d73e9aebcb7d291aa3eb8d5b6926d9a0b77e (diff) | |
If we swap its arguments, SkTaskGroup::batch() _is_ sk_parallel_for.
Why have two names if we can get away with one?
This kills off sk_parallel_for_thread_count(), which was only used to avoid forcing a deadlock in OncePtrTest on multicore machines in singlethreaded mode... a really niche use case. Instead just don't explicitly force a race.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552093002
Review URL: https://codereview.chromium.org/1552093002
Diffstat (limited to 'tests/OnceTest.cpp')
| -rw-r--r-- | tests/OnceTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/OnceTest.cpp b/tests/OnceTest.cpp index 35c2015166..3fd569a42a 100644 --- a/tests/OnceTest.cpp +++ b/tests/OnceTest.cpp @@ -32,7 +32,7 @@ SK_DECLARE_STATIC_ONCE(mt_once); DEF_TEST(SkOnce_Multithreaded, r) { int x = 0; // Run a bunch of tasks to be the first to add six to x. - sk_parallel_for(1021, [&](int) { + SkTaskGroup().batch(1021, [&](int) { void(*add_six)(int*) = [](int* p) { *p += 6; }; SkOnce(&mt_once, add_six, &x); }); |