diff options
author | caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2012-06-06 12:03:39 +0000 |
---|---|---|
committer | caryclark@google.com <caryclark@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2012-06-06 12:03:39 +0000 |
commit | 42639cddc33746b351bbf07c540711eefffe191a (patch) | |
tree | 2032cc41146f1d05732f5e666b1189097dca02f0 /tests/Matrix44Test.cpp | |
parent | 06c279e42a9c69de8d5e8a4a59537422e074a79e (diff) |
fix warnings on Mac in tests
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6301045
git-svn-id: http://skia.googlecode.com/svn/trunk@4175 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/Matrix44Test.cpp')
-rw-r--r-- | tests/Matrix44Test.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/Matrix44Test.cpp b/tests/Matrix44Test.cpp index 9846e7df07..9e589e6aa9 100644 --- a/tests/Matrix44Test.cpp +++ b/tests/Matrix44Test.cpp @@ -76,7 +76,7 @@ static void test_common_angles(skiatest::Reporter* reporter) { } } -void TestMatrix44(skiatest::Reporter* reporter) { +static void TestMatrix44(skiatest::Reporter* reporter) { #ifdef SK_SCALAR_IS_FLOAT SkMatrix44 mat, inverse, iden1, iden2, rot; @@ -139,9 +139,9 @@ void TestMatrix44(skiatest::Reporter* reporter) { 0, 0, 0, 1); } -#if 0 // working on making this pass - test_common_angles(reporter); -#endif + if (false) { // avoid bit rot, suppress warning (working on making this pass) + test_common_angles(reporter); + } #endif } |