diff options
author | bsalomon <bsalomon@google.com> | 2016-04-04 05:56:59 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-04-04 05:56:59 -0700 |
commit | b4b4cf36c66900fdfaf63106d54a8fac786a3313 (patch) | |
tree | a2edd68802089e9b46d65d187fc6e9e47b398c44 /tests/GrContextFactoryTest.cpp | |
parent | aee62f563968437bff0ffdc5aa6185781a81bfd3 (diff) |
Revert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of https://codereview.chromium.org/1845923004/ )
Reason for revert:
Many GM images unexpectedly changed with this CL.
Original issue's description:
> Rename enums in GrContextFactory to remove "GL"
>
> Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004
>
> Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb
TBR=egdaniel@google.com,jvanverth@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1856703002
Diffstat (limited to 'tests/GrContextFactoryTest.cpp')
-rw-r--r-- | tests/GrContextFactoryTest.cpp | 32 |
1 files changed, 17 insertions, 15 deletions
diff --git a/tests/GrContextFactoryTest.cpp b/tests/GrContextFactoryTest.cpp index 6e51b2fda3..bd1888380a 100644 --- a/tests/GrContextFactoryTest.cpp +++ b/tests/GrContextFactoryTest.cpp @@ -20,10 +20,10 @@ DEF_GPUTEST(GrContextFactory_NVPRContextOptionHasPathRenderingSupport, reporter, // or the context creation fails. GrContextFactory testFactory; // Test that if NVPR is possible, caps are in sync. - for (int i = 0; i < GrContextFactory::kContextTypeCnt; ++i) { - GrContextFactory::ContextType ctxType = static_cast<GrContextFactory::ContextType>(i); - GrContext* context = testFactory.get(ctxType, - GrContextFactory::kEnableNVPR_ContextOptions); + for (int i = 0; i < GrContextFactory::kGLContextTypeCnt; ++i) { + GrContextFactory::GLContextType glCtxType = static_cast<GrContextFactory::GLContextType>(i); + GrContext* context = testFactory.get(glCtxType, + GrContextFactory::kEnableNVPR_GLContextOptions); if (!context) { continue; } @@ -37,9 +37,9 @@ DEF_GPUTEST(GrContextFactory_NoPathRenderingUnlessNVPRRequested, reporter, /*fac // Test that if NVPR is not requested, the context never has path rendering support. GrContextFactory testFactory; - for (int i = 0; i <= GrContextFactory::kLastContextType; ++i) { - GrContextFactory::ContextType ctxType = (GrContextFactory::ContextType)i; - GrContext* context = testFactory.get(ctxType); + for (int i = 0; i <= GrContextFactory::kLastGLContextType; ++i) { + GrContextFactory::GLContextType glCtxType = (GrContextFactory::GLContextType)i; + GrContext* context = testFactory.get(glCtxType); if (context) { REPORTER_ASSERT( reporter, @@ -54,15 +54,16 @@ DEF_GPUTEST(GrContextFactory_RequiredSRGBSupport, reporter, /*factory*/) { // created without that flag would not have had sRGB support. GrContextFactory testFactory; // Test that if sRGB is requested, caps are in sync. - for (int i = 0; i < GrContextFactory::kContextTypeCnt; ++i) { - GrContextFactory::ContextType ctxType = static_cast<GrContextFactory::ContextType>(i); + for (int i = 0; i < GrContextFactory::kGLContextTypeCnt; ++i) { + GrContextFactory::GLContextType glCtxType = static_cast<GrContextFactory::GLContextType>(i); GrContext* context = - testFactory.get(ctxType, GrContextFactory::kRequireSRGBSupport_ContextOptions); + testFactory.get(glCtxType, + GrContextFactory::kRequireSRGBSupport_GLContextOptions); if (context) { REPORTER_ASSERT(reporter, context->caps()->srgbSupport()); } else { - context = testFactory.get(ctxType); + context = testFactory.get(glCtxType); if (context) { REPORTER_ASSERT(reporter, !context->caps()->srgbSupport()); } @@ -72,9 +73,10 @@ DEF_GPUTEST(GrContextFactory_RequiredSRGBSupport, reporter, /*factory*/) { DEF_GPUTEST(GrContextFactory_abandon, reporter, /*factory*/) { GrContextFactory testFactory; - for (int i = 0; i < GrContextFactory::kContextTypeCnt; ++i) { - GrContextFactory::ContextType ctxType = (GrContextFactory::ContextType) i; - GrContextFactory::ContextInfo info1 = testFactory.getContextInfo(ctxType); + for (int i = 0; i < GrContextFactory::kGLContextTypeCnt; ++i) { + GrContextFactory::GLContextType glCtxType = (GrContextFactory::GLContextType) i; + GrContextFactory::ContextInfo info1 = + testFactory.getContextInfo(glCtxType); if (!info1.fGrContext) { continue; } @@ -85,7 +87,7 @@ DEF_GPUTEST(GrContextFactory_abandon, reporter, /*factory*/) { // Test that we get different context after abandon. GrContextFactory::ContextInfo info2 = - testFactory.getContextInfo(ctxType); + testFactory.getContextInfo(glCtxType); REPORTER_ASSERT(reporter, info2.fGrContext); REPORTER_ASSERT(reporter, info2.fGLContext); REPORTER_ASSERT(reporter, info1.fGrContext != info2.fGrContext); |