diff options
| author |  mtklein <mtklein@google.com> | 2015-11-18 14:01:07 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-11-18 14:01:07 -0800 |
| commit | c8e8fc6e98e9272293fcf24d53428ddd6129b011 (patch) | |
| tree | 760504b3ab3c6c1bb7c9d348c649b01d28a6efae /tests/GpuDrawPathTest.cpp | |
| parent | a445cbccefb018b8163aae0a0c0a19c850a39be5 (diff) | |
Revert of Fix UB in SkDivBits (patchset #2 id:10002 of https://codereview.chromium.org/1455163004/ )
Reason for revert:
Need to reland with #define guards for tiny layout test changes. (Yikes!)
Original issue's description:
> Fix UB in SkDivBits
>
> DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no.
> This turns numer into a uint32_t to make those defined, and adds a few notes.
>
> x >= 0 is always true for unsigned x, so we needed a few small logic refactors.
>
> BUG=skia:3562
>
> Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123
TBR=caryclark@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3562
Review URL: https://codereview.chromium.org/1457863002
Diffstat (limited to 'tests/GpuDrawPathTest.cpp')
0 files changed, 0 insertions, 0 deletions