diff options
| author |  msarett <msarett@google.com> | 2016-07-19 09:07:55 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-07-19 09:07:55 -0700 |
| commit | 6bdbf4412bd1a6fe26be1042ccf080174b13021f (patch) | |
| tree | b25a250336c9de632cfc40a2e6204626620f099d /tests/Float16Test.cpp | |
| parent | 9061aa4217cabc75aca24f929f370c9a82208e73 (diff) | |
Improve naive SkColorXform to half floats
This should give us a good baseline to explore using SkRasterPipeline.
A particular colorxform to half float drops from 425us to 282us on my desktop.
Color Xform to Half Float (HP z620)
Original 425us
Trans16 (not 32) 355us
Vector Trans16 378us
Trans16 + Keep Halfs in Vector 335us
Vector Trans16 + Keep Halfs in Vector 282us
Final 282us
Color Xform to Half Float (Nexus 5X)
Original 556us
Final 472us
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159993003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2159993003
Diffstat (limited to 'tests/Float16Test.cpp')
| -rw-r--r-- | tests/Float16Test.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/Float16Test.cpp b/tests/Float16Test.cpp index 2091652522..8ab56048e9 100644 --- a/tests/Float16Test.cpp +++ b/tests/Float16Test.cpp @@ -73,7 +73,9 @@ DEF_TEST(HalfToFloat_finite, r) { u(f), f); } REPORTER_ASSERT(r, SkHalfToFloat_finite(h)[0] == f); - REPORTER_ASSERT(r, SkFloatToHalf_finite(SkHalfToFloat_finite(h)) == h); + uint64_t result; + SkFloatToHalf_finite(SkHalfToFloat_finite(h)).store(&result); + REPORTER_ASSERT(r, result == h); } } } @@ -89,7 +91,7 @@ DEF_TEST(FloatToHalf_finite, r) { float f; memcpy(&f, &bits, 4); if (isfinite(f) && isfinite(SkHalfToFloat(SkFloatToHalf(f)))) { - uint16_t h1 = (uint16_t)SkFloatToHalf_finite(Sk4f(f,0,0,0)), + uint16_t h1 = SkFloatToHalf_finite(Sk4f(f,0,0,0))[0], h2 = SkFloatToHalf(f); bool ok = (h1 == h2 || h1 == h2-1); REPORTER_ASSERT(r, ok); |