aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/CodecRecommendedTypeTest.cpp
diff options
context:
space:
mode:
authorGravatar Leon Scroggins III <scroggo@google.com>2017-12-05 13:55:24 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-12-05 19:28:08 +0000
commitc8037dc5edda42cacd839df4e1c7d8cfd0953309 (patch)
treec40be4cadc3ed50a129b05c553c37f69a3310306 /tests/CodecRecommendedTypeTest.cpp
parent89662e698163dbc5a23a7838ce7142cdb1494c88 (diff)
Reland "Hide SkEncodedInfo"
This partially reverts commit 1793e7bb46c1f9d430c1a699a1c3d3168159b659. Hide SkEncodedInfo Bug: skia:7353 Bug: skia:6839 This contains information that is not necessary for clients to know. The Color enum tells the number of components in the input, but this is only interesting internally (to the SkSwizzler). Similarly, the Alpha enum differs from SkAlphaType in that it has kBinary instead of kPremul. This is useful information only internally for determining whether the SkColorSpaceXform needs to premultiply. The bitsPerComponent is potentially useful for a client; Android (in SkAndroidCodec) uses it to determine the SkColorType. Rather than exposing bitsPerComponent, make SkAndroidCodec a friend so it can access the SkEncodedInfo. A future change will change SkCodec to recommend F16 for bitsPerComponent > 8, but that will be more involved; it was the reason for the revert of this CL. Switch conversionSupported to use an SkColorType, which is enough info. Replace the SkEncodedInfo::Alpha field on SkCodec::FrameInfo with an SkAlphaType. SkCodec still needs an SkEncodedInfo, so move its header (which is already not SK_API) to include/private. TBR=mtklein@chromium.org,reed@google.com Change-Id: I928b1f55317602cb37d29da63b53026c8d139cee Reviewed-on: https://skia-review.googlesource.com/80860 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
Diffstat (limited to 'tests/CodecRecommendedTypeTest.cpp')
-rw-r--r--tests/CodecRecommendedTypeTest.cpp40
1 files changed, 40 insertions, 0 deletions
diff --git a/tests/CodecRecommendedTypeTest.cpp b/tests/CodecRecommendedTypeTest.cpp
new file mode 100644
index 0000000000..180bf2f8da
--- /dev/null
+++ b/tests/CodecRecommendedTypeTest.cpp
@@ -0,0 +1,40 @@
+/*
+ * Copyright 2017 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "SkAndroidCodec.h"
+#include "SkBitmap.h"
+#include "SkCodec.h"
+#include "SkColorSpace.h"
+#include "SkEncodedImageFormat.h"
+#include "SkImageEncoder.h"
+#include "SkImageInfo.h"
+#include "SkStream.h"
+
+#include "Test.h"
+
+DEF_TEST(Codec_recommendedF16, r) {
+ // Encode an F16 bitmap. SkEncodeImage will encode this to a true-color PNG
+ // with a bit depth of 16. SkAndroidCodec should always recommend F16 for
+ // such a PNG.
+ SkBitmap bm;
+ bm.allocPixels(SkImageInfo::Make(10, 10, kRGBA_F16_SkColorType,
+ kPremul_SkAlphaType, SkColorSpace::MakeSRGBLinear()));
+ // What is drawn is not important.
+ bm.eraseColor(SK_ColorBLUE);
+
+ SkDynamicMemoryWStream wstream;
+ REPORTER_ASSERT(r, SkEncodeImage(&wstream, bm, SkEncodedImageFormat::kPNG, 100));
+ auto data = wstream.detachAsData();
+ auto androidCodec = SkAndroidCodec::MakeFromData(std::move(data));
+ if (!androidCodec) {
+ ERRORF(r, "Failed to create SkAndroidCodec");
+ return;
+ }
+
+ REPORTER_ASSERT(r, androidCodec->computeOutputColorType(kN32_SkColorType)
+ == kRGBA_F16_SkColorType);
+}