diff options
author | scroggo <scroggo@google.com> | 2014-11-10 13:12:25 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-11-10 13:12:25 -0800 |
commit | b61e206138607423e83ba34d823c6036f394f655 (patch) | |
tree | 643b948ca1751c4268a3a616745995803e45ee58 /tests/BadIcoTest.cpp | |
parent | 428b2a5a4f31334864b2834e8668e7498959580a (diff) |
Add tests (and fix!) for known bad ICO files.
We previously saw crashes decoding bad ICO files. Add tests for
known bad files.
While testing, I learned that one of them still crashes. Check for
large offset and size separately to fix the crash.
BUG=skia:2878
Review URL: https://codereview.chromium.org/712123002
Diffstat (limited to 'tests/BadIcoTest.cpp')
-rw-r--r-- | tests/BadIcoTest.cpp | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/tests/BadIcoTest.cpp b/tests/BadIcoTest.cpp new file mode 100644 index 0000000000..566f3d68a2 --- /dev/null +++ b/tests/BadIcoTest.cpp @@ -0,0 +1,33 @@ +/* + * Copyright 2014 Google Inc. + * + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. + */ + +#include "Resources.h" +#include "Test.h" +#include "SkBitmap.h" +#include "SkImageDecoder.h" +#include "SkOSFile.h" + +DEF_TEST(BadIco, reporter) { + const char* const badIcos [] = { + "sigabort_favicon.ico", + "sigsegv_favicon.ico", + "sigsegv_favicon_2.ico", + }; + + const char* badIcoFolder = "invalid_images"; + + SkString resourcePath = GetResourcePath(badIcoFolder); + + SkBitmap bm; + for (size_t i = 0; i < SK_ARRAY_COUNT(badIcos); ++i) { + SkString fullPath = SkOSPath::Join(resourcePath.c_str(), badIcos[i]); + bool success = SkImageDecoder::DecodeFile(fullPath.c_str(), &bm); + // These files are invalid, and should not decode. More importantly, + // though, we reached here without crashing. + REPORTER_ASSERT(reporter, !success); + } +} |