diff options
author | 2014-01-30 18:58:24 +0000 | |
---|---|---|
committer | 2014-01-30 18:58:24 +0000 | |
commit | 8b0e8ac5f582de80356019406e2975079bf0829d (patch) | |
tree | 9f43589895207dfcf422d41318b371c9540f1ada /tests/AndroidPaintTest.cpp | |
parent | 5fbccb35eb9e7e8cfa3c6b02026206db77990324 (diff) |
Refactor read and write buffers.
Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer
a step each in the hierarchy.
What used to be this:
SkFlattenableWriteBuffer -> SkOrderedWriteBuffer
SkFlattenableReadBuffer -> SkOrderedReadBuffer
SkFlattenableReadBuffer -> SkValidatingReadBuffer
is now
SkWriteBuffer
SkReadBuffer -> SkValidatingReadBuffer
Benefits:
- code is simpler, names are less wordy
- the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed
- write buffers are completely devirtualized, important for record speed
This refactoring was mostly mechanical. You aren't going to find anything
interesting in files with less than 10 lines changed.
BUG=skia:
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/134163010
git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests/AndroidPaintTest.cpp')
-rw-r--r-- | tests/AndroidPaintTest.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/AndroidPaintTest.cpp b/tests/AndroidPaintTest.cpp index 49bab05576..0fc2f9b03a 100644 --- a/tests/AndroidPaintTest.cpp +++ b/tests/AndroidPaintTest.cpp @@ -1,21 +1,21 @@ // SkPaints only have an SkPaintOptionsAndroid if SK_BUILD_FOR_ANDROID is true. #ifdef SK_BUILD_FOR_ANDROID -#include "SkOrderedReadBuffer.h" -#include "SkOrderedWriteBuffer.h" +#include "SkReadBuffer.h" +#include "SkWriteBuffer.h" #include "SkPaint.h" #include "SkPaintOptionsAndroid.h" #include "Test.h" static size_t Reconstruct(const SkPaint& src, SkPaint* dst) { - SkOrderedWriteBuffer writer; + SkWriteBuffer writer; src.flatten(writer); const size_t size = writer.bytesWritten(); SkAutoMalloc bytes(size); writer.writeToMemory(bytes.get()); - SkOrderedReadBuffer reader(bytes.get(), size); + SkReadBuffer reader(bytes.get(), size); dst->unflatten(reader); return size; |