diff options
author | 2013-10-17 17:34:20 +0000 | |
---|---|---|
committer | 2013-10-17 17:34:20 +0000 | |
commit | c2cc1dbe818c8a5a699fbe18c4fc79b9d93daa94 (patch) | |
tree | d9d5b8aa79d17c0a5683a70fd57f92e55de27ca2 /src/utils | |
parent | 4256d2494e80cb6c9a2db4157adc9b9daff028a6 (diff) |
Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/23484007) due to changes to the following GM images:
inverse_paths
pathopsinverse
git-svn-id: http://skia.googlecode.com/svn/trunk@11845 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/utils')
-rw-r--r-- | src/utils/SkDeferredCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/SkDumpCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/SkLuaCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/SkNWayCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/SkProxyCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/debugger/SkDebugCanvas.cpp | 4 | ||||
-rw-r--r-- | src/utils/debugger/SkDebugCanvas.h | 9 |
7 files changed, 16 insertions, 17 deletions
diff --git a/src/utils/SkDeferredCanvas.cpp b/src/utils/SkDeferredCanvas.cpp index bc00ab00d3..ce5eb5e6ab 100644 --- a/src/utils/SkDeferredCanvas.cpp +++ b/src/utils/SkDeferredCanvas.cpp @@ -846,7 +846,7 @@ void SkDeferredCanvas::drawOval(const SkRect& rect, const SkPaint& paint) { this->recordedDrawCommand(); } -void SkDeferredCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkDeferredCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { if (fDeferredDrawing && this->isFullFrame(&rect, &paint) && isPaintOpaque(&paint)) { this->getDeferredDevice()->skipPendingCommands(); @@ -869,7 +869,7 @@ void SkDeferredCanvas::drawRRect(const SkRRect& rrect, const SkPaint& paint) { } } -void SkDeferredCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkDeferredCanvas::drawPath(const SkPath& path, const SkPaint& paint) { AutoImmediateDrawIfNeeded autoDraw(*this, &paint); this->drawingCanvas()->drawPath(path, paint); this->recordedDrawCommand(); diff --git a/src/utils/SkDumpCanvas.cpp b/src/utils/SkDumpCanvas.cpp index 6658ee2a93..0e1a2321e1 100644 --- a/src/utils/SkDumpCanvas.cpp +++ b/src/utils/SkDumpCanvas.cpp @@ -323,7 +323,7 @@ void SkDumpCanvas::drawOval(const SkRect& rect, const SkPaint& paint) { this->dump(kDrawOval_Verb, &paint, "drawOval(%s)", str.c_str()); } -void SkDumpCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkDumpCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { SkString str; toString(rect, &str); this->dump(kDrawRect_Verb, &paint, "drawRect(%s)", str.c_str()); @@ -335,7 +335,7 @@ void SkDumpCanvas::drawRRect(const SkRRect& rrect, const SkPaint& paint) { this->dump(kDrawRRect_Verb, &paint, "drawRRect(%s)", str.c_str()); } -void SkDumpCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkDumpCanvas::drawPath(const SkPath& path, const SkPaint& paint) { SkString str; toString(path, &str); this->dump(kDrawPath_Verb, &paint, "drawPath(%s)", str.c_str()); diff --git a/src/utils/SkLuaCanvas.cpp b/src/utils/SkLuaCanvas.cpp index 3b74596a8e..c5ec006913 100644 --- a/src/utils/SkLuaCanvas.cpp +++ b/src/utils/SkLuaCanvas.cpp @@ -187,7 +187,7 @@ void SkLuaCanvas::drawOval(const SkRect& rect, const SkPaint& paint) { lua.pushPaint(paint, "paint"); } -void SkLuaCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkLuaCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { AUTO_LUA("drawRect"); lua.pushRect(rect, "rect"); lua.pushPaint(paint, "paint"); @@ -199,7 +199,7 @@ void SkLuaCanvas::drawRRect(const SkRRect& rrect, const SkPaint& paint) { lua.pushPaint(paint, "paint"); } -void SkLuaCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkLuaCanvas::drawPath(const SkPath& path, const SkPaint& paint) { AUTO_LUA("drawPath"); lua.pushPath(path, "path"); lua.pushPaint(paint, "paint"); diff --git a/src/utils/SkNWayCanvas.cpp b/src/utils/SkNWayCanvas.cpp index 8075bc4f35..eeb1bc2a09 100644 --- a/src/utils/SkNWayCanvas.cpp +++ b/src/utils/SkNWayCanvas.cpp @@ -190,7 +190,7 @@ void SkNWayCanvas::drawOval(const SkRect& rect, const SkPaint& paint) { } } -void SkNWayCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkNWayCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { Iter iter(fList); while (iter.next()) { iter->drawRect(rect, paint); @@ -204,7 +204,7 @@ void SkNWayCanvas::drawRRect(const SkRRect& rrect, const SkPaint& paint) { } } -void SkNWayCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkNWayCanvas::drawPath(const SkPath& path, const SkPaint& paint) { Iter iter(fList); while (iter.next()) { iter->drawPath(path, paint); diff --git a/src/utils/SkProxyCanvas.cpp b/src/utils/SkProxyCanvas.cpp index 3bc9652d29..f530313b16 100644 --- a/src/utils/SkProxyCanvas.cpp +++ b/src/utils/SkProxyCanvas.cpp @@ -87,7 +87,7 @@ void SkProxyCanvas::drawOval(const SkRect& rect, const SkPaint& paint) { fProxy->drawOval(rect, paint); } -void SkProxyCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkProxyCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { fProxy->drawRect(rect, paint); } @@ -95,7 +95,7 @@ void SkProxyCanvas::drawRRect(const SkRRect& rrect, const SkPaint& paint) { fProxy->drawRRect(rrect, paint); } -void SkProxyCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkProxyCanvas::drawPath(const SkPath& path, const SkPaint& paint) { fProxy->drawPath(path, paint); } diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp index 2add91465b..bf81983548 100644 --- a/src/utils/debugger/SkDebugCanvas.cpp +++ b/src/utils/debugger/SkDebugCanvas.cpp @@ -321,7 +321,7 @@ void SkDebugCanvas::drawPaint(const SkPaint& paint) { addDrawCommand(new SkDrawPaintCommand(paint)); } -void SkDebugCanvas::onDrawPath(const SkPath& path, const SkPaint& paint) { +void SkDebugCanvas::drawPath(const SkPath& path, const SkPaint& paint) { addDrawCommand(new SkDrawPathCommand(path, paint)); } @@ -345,7 +345,7 @@ void SkDebugCanvas::drawPosTextH(const void* text, size_t byteLength, new SkDrawPosTextHCommand(text, byteLength, xpos, constY, paint)); } -void SkDebugCanvas::onDrawRect(const SkRect& rect, const SkPaint& paint) { +void SkDebugCanvas::drawRect(const SkRect& rect, const SkPaint& paint) { // NOTE(chudy): Messing up when renamed to DrawRect... Why? addDrawCommand(new SkDrawRectCommand(rect, paint)); } diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h index 2b17b6ff93..705f49af83 100644 --- a/src/utils/debugger/SkDebugCanvas.h +++ b/src/utils/debugger/SkDebugCanvas.h @@ -182,6 +182,8 @@ public: virtual void drawPaint(const SkPaint& paint) SK_OVERRIDE; + virtual void drawPath(const SkPath& path, const SkPaint&) SK_OVERRIDE; + virtual void drawPicture(SkPicture& picture) SK_OVERRIDE; virtual void drawPoints(PointMode, size_t count, const SkPoint pts[], @@ -194,6 +196,8 @@ public: const SkScalar xpos[], SkScalar constY, const SkPaint&) SK_OVERRIDE; + virtual void drawRect(const SkRect& rect, const SkPaint&) SK_OVERRIDE; + virtual void drawRRect(const SkRRect& rrect, const SkPaint& paint) SK_OVERRIDE; virtual void drawSprite(const SkBitmap&, int left, int top, @@ -231,11 +235,6 @@ public: static const int kVizImageHeight = 256; static const int kVizImageWidth = 256; -protected: - virtual void onDrawRect(const SkRect& rect, const SkPaint&) SK_OVERRIDE; - - virtual void onDrawPath(const SkPath& path, const SkPaint&) SK_OVERRIDE; - private: SkTDArray<SkDrawCommand*> fCommandVector; int fHeight; |