aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/utils
diff options
context:
space:
mode:
authorGravatar scroggo <scroggo@google.com>2015-09-30 11:33:12 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-09-30 11:33:12 -0700
commit7fac5af5e9310826721ff416bdbe71294d607b2a (patch)
treeb199371e4f4e00d5a8f870ec5872a05d04c9ba22 /src/utils
parent56c6a117b222aa7d94843cfe6058e085d4394d97 (diff)
Fix bug testing SkCodec for ICO
Looking in Gold, I see some ICO images that only show the upper left corner of the originals. It is happening because we use different ways of deciding what the dimensions are: In CodecSrc::size(), we use an SkScaledCodec to get the dimensions, even when fMode is not kScaledCodec_Mode. In CodecSrc::draw(), we only use SkScaledCodec in kScaledCodec_Mode. My recent CL to combine SkScanlineDecoder with SkCodec revealed this bug, because now SkScaledCodec::NewFromStream will succeed on ICO. (Previously, it failed because we do not yet have a scanline decoder for ICO (skbug.com/4404). Now that they are combined, we would need to specially flag ICO to stop returning an SkScaledCodec.) Switch size() to use the correct type of codec. Review URL: https://codereview.chromium.org/1373253004
Diffstat (limited to 'src/utils')
0 files changed, 0 insertions, 0 deletions