aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/utils/debugger
diff options
context:
space:
mode:
authorGravatar robertphillips <robertphillips@google.com>2015-03-26 10:08:04 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-03-26 10:08:04 -0700
commit546db46a76ad5f7485cebeb27efaf8b4806fa914 (patch)
tree107661e571f74db9d8cc101b2a8d5ba31dad7f3c /src/utils/debugger
parent0eed6df064e6d148ddc330531d584ddd1bd4e6db (diff)
Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents)
Displaying the offset into an SkPicture hasn't worked for a while so this CL deletes the feature. When "Save Layer" was renamed to "SaveLayer" the code that computes the indent in the list view was broken. This CL patches the problem. Review URL: https://codereview.chromium.org/1034733004
Diffstat (limited to 'src/utils/debugger')
-rw-r--r--src/utils/debugger/SkDebugCanvas.cpp1
-rw-r--r--src/utils/debugger/SkDebugCanvas.h9
-rw-r--r--src/utils/debugger/SkDrawCommand.cpp1
-rw-r--r--src/utils/debugger/SkDrawCommand.h4
4 files changed, 0 insertions, 15 deletions
diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp
index 4b5e03bf1f..b1e906ae90 100644
--- a/src/utils/debugger/SkDebugCanvas.cpp
+++ b/src/utils/debugger/SkDebugCanvas.cpp
@@ -128,7 +128,6 @@ SkDebugCanvas::~SkDebugCanvas() {
}
void SkDebugCanvas::addDrawCommand(SkDrawCommand* command) {
- command->setOffset(this->getOpID());
fCommandVector.push(command);
}
diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h
index 35dd6fb92d..8cf16d2f02 100644
--- a/src/utils/debugger/SkDebugCanvas.h
+++ b/src/utils/debugger/SkDebugCanvas.h
@@ -255,15 +255,6 @@ private:
*/
void applyUserTransform(SkCanvas* canvas);
- size_t getOpID() const {
-#if 0
- if (fPicture) {
- return fPicture->EXPERIMENTAL_curOpID();
- }
-#endif
- return 0;
- }
-
void resetClipStackData() { fClipStackData.reset(); fCalledAddStackData = false; }
void addClipStackData(const SkPath& devPath, const SkPath& operand, SkRegion::Op elementOp);
diff --git a/src/utils/debugger/SkDrawCommand.cpp b/src/utils/debugger/SkDrawCommand.cpp
index 38f02d9616..d09de78351 100644
--- a/src/utils/debugger/SkDrawCommand.cpp
+++ b/src/utils/debugger/SkDrawCommand.cpp
@@ -16,7 +16,6 @@
SkDrawCommand::SkDrawCommand(OpType type)
: fOpType(type)
- , fOffset(0)
, fVisible(true) {
}
diff --git a/src/utils/debugger/SkDrawCommand.h b/src/utils/debugger/SkDrawCommand.h
index 9e25f4d20d..760ce52052 100644
--- a/src/utils/debugger/SkDrawCommand.h
+++ b/src/utils/debugger/SkDrawCommand.h
@@ -59,9 +59,6 @@ public:
virtual SkString toString() const;
- void setOffset(size_t offset) { fOffset = offset; }
- size_t offset() const { return fOffset; }
-
virtual const char* toCString() const {
return GetCommandString(fOpType);
}
@@ -106,7 +103,6 @@ protected:
private:
OpType fOpType;
- size_t fOffset;
bool fVisible;
};