SkTCopyOnFirstWrite-based SkPaintFilterCanvas API

I find this version preferable because

1) it consolidates the in/out paint args without compromising
efficiency or flexibility

2) relieves overriders from having to set the SkTLazy explicitly

BUG=skia:4782
R=mtklein@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1576183002

Review URL: https://codereview.chromium.org/1576183002

1 files changed, 5 insertions, 6 deletions

diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp
index 9f11a9e3f3..63739aee81 100644
--- a/src/utils/debugger/SkDebugCanvas.cpp
+++ b/src/utils/debugger/SkDebugCanvas.cpp
@@ -69,16 +69,15 @@ public:
         , fFilterQuality(quality) {}
 
 protected:
-    bool onFilter(const SkPaint* paint, Type, SkTLazy<SkPaint>* filteredPaint) const override {
-        if (paint) {
-            filteredPaint->set(*paint);
+    bool onFilter(SkTCopyOnFirstWrite<SkPaint>* paint, Type) const override {
+        if (*paint) {
             if (nullptr != fOverdrawXfermode.get()) {
-                filteredPaint->get()->setAntiAlias(false);
-                filteredPaint->get()->setXfermode(fOverdrawXfermode.get());
+                paint->writable()->setAntiAlias(false);
+                paint->writable()->setXfermode(fOverdrawXfermode.get());
             }
 
             if (fOverrideFilterQuality) {
-                filteredPaint->get()->setFilterQuality(fFilterQuality);
+                paint->writable()->setFilterQuality(fFilterQuality);
             }
         }
         return true;