aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/utils/SkCanvasStateUtils.cpp
diff options
context:
space:
mode:
authorGravatar scroggo <scroggo@google.com>2014-07-22 12:38:55 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-07-22 12:38:55 -0700
commit24519371cb541db6f59d903d21878ed9c45eb549 (patch)
tree3aeaca2a3da03607d7494c8b3deef5c4045a9d07 /src/utils/SkCanvasStateUtils.cpp
parentc0bc9134514a4f138621203a6f7d4553ebec238a (diff)
Run CanvasState test across a library boundary.
Refactor CanvasStateTest to pull out functions which can either be called directly or from a shared library. Add a command line flag to pass in the path to a library to open to call those functions from. Separate different CanvasTest tests into separate DEF_TEST tests. This allows them to be run in parallel. Move the ifdefs outside of function declarations to skip running CanvasTest tests which do nothing. Add the canvas_state_lib target. It is a shared library that exports some functions to be called by another version of Skia. BUG=b/15693384 R=djsollen@google.com, reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/400043003
Diffstat (limited to 'src/utils/SkCanvasStateUtils.cpp')
-rw-r--r--src/utils/SkCanvasStateUtils.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/utils/SkCanvasStateUtils.cpp b/src/utils/SkCanvasStateUtils.cpp
index e286c9138f..a6806ddc7c 100644
--- a/src/utils/SkCanvasStateUtils.cpp
+++ b/src/utils/SkCanvasStateUtils.cpp
@@ -20,6 +20,11 @@
* ANY CHANGES TO THE STRUCTS BELOW THAT IMPACT THE ABI SHOULD RESULT IN A NEW
* NEW SUBCLASS OF SkCanvasState. SUCH CHANGES SHOULD ONLY BE MADE IF ABSOLUTELY
* NECESSARY!
+ *
+ * In order to test changes, run the CanvasState tests. gyp/canvas_state_lib.gyp
+ * describes how to create a library to pass to the CanvasState tests. The tests
+ * should succeed when building the library with your changes and passing that to
+ * the tests running in the unchanged Skia.
*/
enum RasterConfigs {
kUnknown_RasterConfig = 0,