diff options
author | reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-17 16:44:46 +0000 |
---|---|---|
committer | reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-17 16:44:46 +0000 |
commit | 8f4d2306fa866a26f9448048ff63f692b2ba43aa (patch) | |
tree | 7a48d817cb5220f87e81781320b002eead2495a0 /src/utils/SkCamera.cpp | |
parent | a34b638b909f58dd7c66546a0f49923112f7f785 (diff) |
remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats
To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.
BUG=
R=bsalomon@google.com, caryclark@google.com
Review URL: https://codereview.chromium.org/117053002
git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/utils/SkCamera.cpp')
-rw-r--r-- | src/utils/SkCamera.cpp | 48 |
1 files changed, 0 insertions, 48 deletions
diff --git a/src/utils/SkCamera.cpp b/src/utils/SkCamera.cpp index f5b51d5259..2e2031e386 100644 --- a/src/utils/SkCamera.cpp +++ b/src/utils/SkCamera.cpp @@ -12,7 +12,6 @@ static SkScalar SkScalarDotDiv(int count, const SkScalar a[], int step_a, const SkScalar b[], int step_b, SkScalar denom) { -#ifdef SK_SCALAR_IS_FLOAT float prod = 0; for (int i = 0; i < count; i++) { prod += a[0] * b[0]; @@ -20,24 +19,10 @@ static SkScalar SkScalarDotDiv(int count, const SkScalar a[], int step_a, b += step_b; } return prod / denom; -#else - Sk64 prod, tmp; - - prod.set(0); - for (int i = 0; i < count; i++) { - tmp.setMul(a[0], b[0]); - prod.add(tmp); - a += step_a; - b += step_b; - } - prod.div(denom, Sk64::kRound_DivOption); - return prod.get32(); -#endif } static SkScalar SkScalarDot(int count, const SkScalar a[], int step_a, const SkScalar b[], int step_b) { -#ifdef SK_SCALAR_IS_FLOAT float prod = 0; for (int i = 0; i < count; i++) { prod += a[0] * b[0]; @@ -45,24 +30,11 @@ static SkScalar SkScalarDot(int count, const SkScalar a[], int step_a, b += step_b; } return prod; -#else - Sk64 prod, tmp; - - prod.set(0); - for (int i = 0; i < count; i++) { - tmp.setMul(a[0], b[0]); - prod.add(tmp); - a += step_a; - b += step_b; - } - return prod.getFixed(); -#endif } /////////////////////////////////////////////////////////////////////////////// SkUnitScalar SkPoint3D::normalize(SkUnit3D* unit) const { -#ifdef SK_SCALAR_IS_FLOAT float mag = sk_float_sqrt(fX*fX + fY*fY + fZ*fZ); if (mag) { float scale = 1.0f / mag; @@ -72,26 +44,6 @@ SkUnitScalar SkPoint3D::normalize(SkUnit3D* unit) const { } else { unit->fX = unit->fY = unit->fZ = 0; } -#else - Sk64 tmp1, tmp2; - - tmp1.setMul(fX, fX); - tmp2.setMul(fY, fY); - tmp1.add(tmp2); - tmp2.setMul(fZ, fZ); - tmp1.add(tmp2); - - SkFixed mag = tmp1.getSqrt(); - if (mag) { - // what if mag < SK_Fixed1 ??? we will underflow the fixdiv - SkFixed scale = SkFixedDiv(SK_Fract1, mag); - unit->fX = SkFixedMul(fX, scale); - unit->fY = SkFixedMul(fY, scale); - unit->fZ = SkFixedMul(fZ, scale); - } else { - unit->fX = unit->fY = unit->fZ = 0; - } -#endif return mag; } |