diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-06-02 13:52:38 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-06-02 13:57:39 +0000 |
commit | affa6a3da87e9ea85f1d4fe3137b5bccbbc56f92 (patch) | |
tree | ccaa2cbc3e395a140b25f23bf250e948525a1541 /src/sksl/ir/SkSLVarDeclarationsStatement.h | |
parent | 370c2b304a35297d36fcee91e3b6ac516091434d (diff) |
Revert "Fixed an issue with sksl variable declarations"
This reverts commit 88bd8edcff23dc9cf31b664cba7ba73b235318b0.
Reason for revert: unhappy bots
Original change's description:
> Fixed an issue with sksl variable declarations
>
> There was an issue where multiple variables defined in the same
> declaration were not being sequenced appropriately during analysis, so
> 'int x = 0, y = x + 1' would report that x was undefined.
>
> Bug: skia:
> Change-Id: I882f7e216467306f6a6013a0a34aac30a4c60744
> Reviewed-on: https://skia-review.googlesource.com/18313
> Reviewed-by: Chris Dalton <csmartdalton@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
>
TBR=csmartdalton@google.com,ethannicholas@google.com
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Change-Id: Ibc68674289dce70b6173a347a0e78bb0f1e6db1b
Reviewed-on: https://skia-review.googlesource.com/18457
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Diffstat (limited to 'src/sksl/ir/SkSLVarDeclarationsStatement.h')
-rw-r--r-- | src/sksl/ir/SkSLVarDeclarationsStatement.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/sksl/ir/SkSLVarDeclarationsStatement.h b/src/sksl/ir/SkSLVarDeclarationsStatement.h index ab6753610f..50365decc1 100644 --- a/src/sksl/ir/SkSLVarDeclarationsStatement.h +++ b/src/sksl/ir/SkSLVarDeclarationsStatement.h @@ -21,15 +21,6 @@ struct VarDeclarationsStatement : public Statement { : INHERITED(decl->fPosition, kVarDeclarations_Kind) , fDeclaration(std::move(decl)) {} - bool isEmpty() const override { - for (const auto& s : fDeclaration->fVars) { - if (!s->isEmpty()) { - return false; - } - } - return true; - } - String description() const override { return fDeclaration->description(); } |