diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-01-19 10:44:45 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-01-19 16:17:36 +0000 |
commit | f54b07121f81a56145fb118a2e18841fc135717d (patch) | |
tree | 088966a79e4f01641af5f198f985b07b9144b267 /src/sksl/ir/SkSLProgram.h | |
parent | 189098e70967c05c8810299b4afa325736a6565e (diff) |
Added constant propagation and better variable liveness tracking to
skslc.
This allows skslc to track the values of variables with constant
values across multiple statements and replace variable references with
constant values where appropriate.
The improved liveness tracking allows skslc to realize that a
variable is no longer alive if all references to it have been
replaced. It is not yet doing much with this information; better
dead code elimination is coming in a followup change.
BUG=skia:
Change-Id: I6bf267d478b769caf0063ac3597dc16bbe618cb4
Reviewed-on: https://skia-review.googlesource.com/7033
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'src/sksl/ir/SkSLProgram.h')
-rw-r--r-- | src/sksl/ir/SkSLProgram.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/sksl/ir/SkSLProgram.h b/src/sksl/ir/SkSLProgram.h index ac49d6dcc7..6a73be6983 100644 --- a/src/sksl/ir/SkSLProgram.h +++ b/src/sksl/ir/SkSLProgram.h @@ -59,8 +59,8 @@ struct Program { , fSettings(settings) , fDefaultPrecision(defaultPrecision) , fContext(context) - , fElements(std::move(elements)) , fSymbols(symbols) + , fElements(std::move(elements)) , fInputs(inputs) {} Kind fKind; @@ -68,8 +68,10 @@ struct Program { // FIXME handle different types; currently it assumes this is for floats Modifiers::Flag fDefaultPrecision; Context* fContext; - std::vector<std::unique_ptr<ProgramElement>> fElements; + // it's important to keep fElements defined after (and thus destroyed before) fSymbols, + // because destroying elements can modify reference counts in symbols std::shared_ptr<SymbolTable> fSymbols; + std::vector<std::unique_ptr<ProgramElement>> fElements; Inputs fInputs; }; |