diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-09-07 15:44:01 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-11 16:17:00 +0000 |
commit | c576e93d174f3106e072a2f506bca3990b541265 (patch) | |
tree | d4a410200aa71183c95643535b440bec919f2e18 /src/sksl/ir/SkSLIRNode.h | |
parent | a2bdf005f3c706065d1aa93f319f4b73932721d4 (diff) |
Switch to the new SkSL lexer.
This completely replaces flex with a new in-house lexical analyzer generator,
which we have done for performance and memory usage reasons. Flex requires us
to copy strings every time we need the text of a token, whereas this new lexer
allows us to handle strings as a (non-null-terminated) pointer and length
everywhere, eliminating most string copies.
Bug: skia:
Change-Id: I2add26efc9e20cb699520e82abcf713af3968aca
Reviewed-on: https://skia-review.googlesource.com/39780
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Diffstat (limited to 'src/sksl/ir/SkSLIRNode.h')
-rw-r--r-- | src/sksl/ir/SkSLIRNode.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/sksl/ir/SkSLIRNode.h b/src/sksl/ir/SkSLIRNode.h index 139be32f44..5ada50607e 100644 --- a/src/sksl/ir/SkSLIRNode.h +++ b/src/sksl/ir/SkSLIRNode.h @@ -8,7 +8,7 @@ #ifndef SKSL_IRNODE #define SKSL_IRNODE -#include "../SkSLPosition.h" +#include "../SkSLLexer.h" namespace SkSL { @@ -17,14 +17,16 @@ namespace SkSL { * version of the program (all types determined, everything validated), ready for code generation. */ struct IRNode { - IRNode(Position position) - : fPosition(position) {} + IRNode(int offset) + : fOffset(offset) {} virtual ~IRNode() {} virtual String description() const = 0; - const Position fPosition; + // character offset of this element within the program being compiled, for error reporting + // purposes + const int fOffset; }; } // namespace |