diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-01-19 13:32:00 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-01-19 20:11:40 +0000 |
commit | 86a43405fb3f83f6d45581959df5f7321487ae7e (patch) | |
tree | 4d367433d67af533d96fcbc80abe192010219427 /src/sksl/ir/SkSLBlock.h | |
parent | 4f364fd951eac36adbc1c8719f3e7c42974dfad1 (diff) |
Added constant propagation and better variable liveness tracking to skslc.
This allows skslc to track the values of variables with constant
values across multiple statements and replace variable references with
constant values where appropriate.
The improved liveness tracking allows skslc to realize that a
variable is no longer alive if all references to it have been
replaced. It is not yet doing much with this information; better
dead code elimination is coming in a followup change.
BUG=skia:
Change-Id: I068c5d2e9a362e75299b1de1f4575339f5ddc3bb
Reviewed-on: https://skia-review.googlesource.com/7302
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Diffstat (limited to 'src/sksl/ir/SkSLBlock.h')
-rw-r--r-- | src/sksl/ir/SkSLBlock.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/sksl/ir/SkSLBlock.h b/src/sksl/ir/SkSLBlock.h index f975d160a0..17970fd561 100644 --- a/src/sksl/ir/SkSLBlock.h +++ b/src/sksl/ir/SkSLBlock.h @@ -20,8 +20,8 @@ struct Block : public Statement { Block(Position position, std::vector<std::unique_ptr<Statement>> statements, const std::shared_ptr<SymbolTable> symbols) : INHERITED(position, kBlock_Kind) - , fStatements(std::move(statements)) - , fSymbols(std::move(symbols)) {} + , fSymbols(std::move(symbols)) + , fStatements(std::move(statements)) {} SkString description() const override { SkString result("{"); @@ -33,8 +33,10 @@ struct Block : public Statement { return result; } - const std::vector<std::unique_ptr<Statement>> fStatements; + // it's important to keep fStatements defined after (and thus destroyed before) fSymbols, + // because destroying statements can modify reference counts in symbols const std::shared_ptr<SymbolTable> fSymbols; + const std::vector<std::unique_ptr<Statement>> fStatements; typedef Statement INHERITED; }; |