diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-03-30 18:42:48 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-03-30 18:42:59 +0000 |
commit | bcf35f86d50b784b165de703b404998dd4299f6a (patch) | |
tree | 9fcd85326b1a5dbda864da9431a878bb62f65191 /src/sksl/SkSLParser.h | |
parent | 7833466da45bfa1e078427c4a6db94d41c5c1535 (diff) |
Revert "skslc can now be compiled with no Skia dependencies, in preparation for"
This reverts commit 7833466da45bfa1e078427c4a6db94d41c5c1535.
Reason for revert: Vulkan assertion failure
Original change's description:
> skslc can now be compiled with no Skia dependencies, in preparation for
> its eventual role in Skia's build process.
>
> Bug: skia:
> Change-Id: Iaa9933f4fc4a64bec60aa897c509a3513f457a78
> Reviewed-on: https://skia-review.googlesource.com/10282
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
>
TBR=egdaniel@google.com,benjaminwagner@google.com,ethannicholas@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ic64cac2395abb406116885ddd725f74a434c8c49
Reviewed-on: https://skia-review.googlesource.com/10758
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Diffstat (limited to 'src/sksl/SkSLParser.h')
-rw-r--r-- | src/sksl/SkSLParser.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/sksl/SkSLParser.h b/src/sksl/SkSLParser.h index 0fa00cb882..9be017ce62 100644 --- a/src/sksl/SkSLParser.h +++ b/src/sksl/SkSLParser.h @@ -51,7 +51,7 @@ class SymbolTable; */ class Parser { public: - Parser(String text, SymbolTable& types, ErrorReporter& errors); + Parser(SkString text, SymbolTable& types, ErrorReporter& errors); ~Parser(); @@ -90,16 +90,16 @@ private: * Returns true if the read token was as expected, false otherwise. */ bool expect(Token::Kind kind, const char* expected, Token* result = nullptr); - bool expect(Token::Kind kind, String expected, Token* result = nullptr); + bool expect(Token::Kind kind, SkString expected, Token* result = nullptr); void error(Position p, const char* msg); - void error(Position p, String msg); - + void error(Position p, SkString msg); + /** * Returns true if the 'name' identifier refers to a type name. For instance, isType("int") will * always return true. */ - bool isType(String name); + bool isType(SkString name); // these functions parse individual grammar rules from the current parse position; you probably // don't need to call any of these outside of the parser. The function declarations in the .cpp @@ -119,12 +119,12 @@ private: std::unique_ptr<ASTVarDeclarations> varDeclarationEnd(Modifiers modifiers, std::unique_ptr<ASTType> type, - String name); + SkString name); std::unique_ptr<ASTParameter> parameter(); int layoutInt(); - + Layout layout(); Modifiers modifiers(); @@ -164,7 +164,7 @@ private: std::unique_ptr<ASTExpression> expression(); std::unique_ptr<ASTExpression> assignmentExpression(); - + std::unique_ptr<ASTExpression> ternaryExpression(); std::unique_ptr<ASTExpression> logicalOrExpression(); @@ -203,7 +203,7 @@ private: bool boolLiteral(bool* dest); - bool identifier(String* dest); + bool identifier(SkString* dest); void* fScanner; void* fLayoutScanner; |