diff options
author | Ethan Nicholas <ethannicholas@google.com> | 2017-09-11 16:33:48 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-11 16:34:02 +0000 |
commit | 358515491a0d6891e6a709688a30ad087df1beb1 (patch) | |
tree | ce64223230053df7db85c94b848ad526e64269cd /src/sksl/SkSLIRGenerator.h | |
parent | c576e93d174f3106e072a2f506bca3990b541265 (diff) |
Revert "Switch to the new SkSL lexer."
This reverts commit c576e93d174f3106e072a2f506bca3990b541265.
Reason for revert: ASAN failures
Original change's description:
> Switch to the new SkSL lexer.
>
> This completely replaces flex with a new in-house lexical analyzer generator,
> which we have done for performance and memory usage reasons. Flex requires us
> to copy strings every time we need the text of a token, whereas this new lexer
> allows us to handle strings as a (non-null-terminated) pointer and length
> everywhere, eliminating most string copies.
>
> Bug: skia:
> Change-Id: I2add26efc9e20cb699520e82abcf713af3968aca
> Reviewed-on: https://skia-review.googlesource.com/39780
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
TBR=bsalomon@google.com,ethannicholas@google.com
Change-Id: If27b750a5f696d06a6bcffed12fe9f0598e084a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/44881
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Diffstat (limited to 'src/sksl/SkSLIRGenerator.h')
-rw-r--r-- | src/sksl/SkSLIRGenerator.h | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/src/sksl/SkSLIRGenerator.h b/src/sksl/SkSLIRGenerator.h index 3dda02835b..0a1bae4f64 100644 --- a/src/sksl/SkSLIRGenerator.h +++ b/src/sksl/SkSLIRGenerator.h @@ -61,8 +61,7 @@ public: IRGenerator(const Context* context, std::shared_ptr<SymbolTable> root, ErrorReporter& errorReporter); - void convertProgram(const char* text, - size_t length, + void convertProgram(String text, SymbolTable& types, Modifiers::Flag* defaultPrecision, std::vector<std::unique_ptr<ProgramElement>>* result); @@ -104,26 +103,26 @@ private: const ASTModifiersDeclaration& m); const Type* convertType(const ASTType& type); - std::unique_ptr<Expression> call(int offset, + std::unique_ptr<Expression> call(Position position, const FunctionDeclaration& function, std::vector<std::unique_ptr<Expression>> arguments); int callCost(const FunctionDeclaration& function, const std::vector<std::unique_ptr<Expression>>& arguments); - std::unique_ptr<Expression> call(int offset, std::unique_ptr<Expression> function, + std::unique_ptr<Expression> call(Position position, std::unique_ptr<Expression> function, std::vector<std::unique_ptr<Expression>> arguments); int coercionCost(const Expression& expr, const Type& type); std::unique_ptr<Expression> coerce(std::unique_ptr<Expression> expr, const Type& type); std::unique_ptr<Block> convertBlock(const ASTBlock& block); std::unique_ptr<Statement> convertBreak(const ASTBreakStatement& b); std::unique_ptr<Expression> convertNumberConstructor( - int offset, + Position position, const Type& type, std::vector<std::unique_ptr<Expression>> params); std::unique_ptr<Expression> convertCompoundConstructor( - int offset, + Position position, const Type& type, std::vector<std::unique_ptr<Expression>> params); - std::unique_ptr<Expression> convertConstructor(int offset, + std::unique_ptr<Expression> convertConstructor(Position position, const Type& type, std::vector<std::unique_ptr<Expression>> params); std::unique_ptr<Statement> convertContinue(const ASTContinueStatement& c); @@ -143,13 +142,13 @@ private: std::unique_ptr<Expression> convertPrefixExpression(const ASTPrefixExpression& expression); std::unique_ptr<Statement> convertReturn(const ASTReturnStatement& r); std::unique_ptr<Section> convertSection(const ASTSection& e); - std::unique_ptr<Expression> getCap(int offset, String name); - std::unique_ptr<Expression> getArg(int offset, String name); + std::unique_ptr<Expression> getCap(Position position, String name); + std::unique_ptr<Expression> getArg(Position position, String name); std::unique_ptr<Expression> convertSuffixExpression(const ASTSuffixExpression& expression); std::unique_ptr<Expression> convertField(std::unique_ptr<Expression> base, - StringFragment field); + const String& field); std::unique_ptr<Expression> convertSwizzle(std::unique_ptr<Expression> base, - StringFragment fields); + const String& fields); std::unique_ptr<Expression> convertTernaryExpression(const ASTTernaryExpression& expression); std::unique_ptr<Statement> convertVarDeclarationStatement(const ASTVarDeclarationStatement& s); std::unique_ptr<Statement> convertWhile(const ASTWhileStatement& w); |