aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/shaders
diff options
context:
space:
mode:
authorGravatar Mike Reed <reed@google.com>2018-01-03 13:17:18 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-01-03 20:03:59 +0000
commitc5166a9dcbf2eeb95cb8e2918271132aa34bf5cd (patch)
tree552bcec5b3d9d6a6889ed1787c5811e72c706212 /src/shaders
parent3c36ef6be93400368fee3ea2e0dca6cff4972bb0 (diff)
Revert "Revert "remove legacy support for old old picture versions""
This reverts commit 6f1151140f331c78d99ede3cac10462dc8b32cde. Chrome has been updated, so this should be able to land. Bug: skia: Change-Id: I5a66782a39fecfac00edeb66fbd03dae4df1712c Reviewed-on: https://skia-review.googlesource.com/90205 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'src/shaders')
-rw-r--r--src/shaders/SkComposeShader.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/src/shaders/SkComposeShader.cpp b/src/shaders/SkComposeShader.cpp
index 34e54863b7..2feae7788e 100644
--- a/src/shaders/SkComposeShader.cpp
+++ b/src/shaders/SkComposeShader.cpp
@@ -43,17 +43,12 @@ sk_sp<SkFlattenable> SkComposeShader::CreateProc(SkReadBuffer& buffer) {
sk_sp<SkShader> dst(buffer.readShader());
sk_sp<SkShader> src(buffer.readShader());
unsigned mode = buffer.read32();
-
- float lerp = 1;
- if (!buffer.isVersionLT(SkReadBuffer::kComposeShaderCanLerp_Version)) {
- lerp = buffer.readScalar();
- }
+ float lerp = buffer.readScalar();
// check for valid mode before we cast to the enum type
- if (mode > (unsigned)SkBlendMode::kLastMode) {
+ if (!buffer.validate(mode <= (unsigned)SkBlendMode::kLastMode)) {
return nullptr;
}
-
return MakeCompose(std::move(dst), std::move(src), static_cast<SkBlendMode>(mode), lerp);
}