diff options
| author |  Florin Malita <fmalita@chromium.org> | 2017-07-12 13:31:25 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-07-12 20:36:45 +0000 |
| commit | 5769dd2c9ad9443b8cf2d62748d5747e547c7ad5 (patch) | |
| tree | 912ab12f89b385392d5db0da9700e40968fa69f7 /src/shaders/SkImageShader.h | |
| parent | d4b2c537d058ad4cb890ba116d00aa86c3416c08 (diff) | |
Add some raster pipeline perspective asserts
I meant to add these when removing the guard, but since we landed without
a guard, might as well do it now.
A couple of things exposed by these asserts:
1) we need to also catch perspective in local matrices
2) we need to disallow burst mode with perspective
Also tweak the predicate to hasPerspective() instead of explicit mask
check.
Change-Id: I099e5125fca52dccffca77c60fc800bbdf539b53
Reviewed-on: https://skia-review.googlesource.com/22483
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'src/shaders/SkImageShader.h')
| -rw-r--r-- | src/shaders/SkImageShader.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/shaders/SkImageShader.h b/src/shaders/SkImageShader.h index e68abb5d5a..a2bd3a63f0 100644 --- a/src/shaders/SkImageShader.h +++ b/src/shaders/SkImageShader.h @@ -19,7 +19,6 @@ public: const SkMatrix* localMatrix); bool isOpaque() const override; - bool isRasterPipelineOnly() const override; SK_TO_STRING_OVERRIDE() SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkImageShader) @@ -40,6 +39,8 @@ protected: #endif SkImage* onIsAImage(SkMatrix*, TileMode*) const override; + bool onIsRasterPipelineOnly() const override; + bool onAppendStages(SkRasterPipeline*, SkColorSpace*, SkArenaAlloc*, const SkMatrix& ctm, const SkPaint&, const SkMatrix*) const override; |