diff options
author | vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-03-13 20:01:51 +0000 |
---|---|---|
committer | vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-03-13 20:01:51 +0000 |
commit | dcf9c19d38d366a9f27ad0d8b5bda327c5edb164 (patch) | |
tree | 35acb3dcaa263aebf029d82cb32e7d222dd621eb /src/ports | |
parent | d34fda187cdbd00eee08a75d1c9420288babafc0 (diff) |
[PDF] Always set the symbolic Flag for Fonts.
This should fix Chrome bug 124572
Review URL: https://codereview.appspot.com/7631045
git-svn-id: http://skia.googlecode.com/svn/trunk@8136 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/ports')
-rw-r--r-- | src/ports/SkFontHost_FreeType.cpp | 3 | ||||
-rwxr-xr-x | src/ports/SkFontHost_mac.cpp | 3 | ||||
-rwxr-xr-x | src/ports/SkFontHost_win.cpp | 2 | ||||
-rw-r--r-- | src/ports/SkFontHost_win_dw.cpp | 2 |
4 files changed, 0 insertions, 10 deletions
diff --git a/src/ports/SkFontHost_FreeType.cpp b/src/ports/SkFontHost_FreeType.cpp index 9422cf99d3..40d939c17c 100644 --- a/src/ports/SkFontHost_FreeType.cpp +++ b/src/ports/SkFontHost_FreeType.cpp @@ -499,9 +499,6 @@ SkAdvancedTypefaceMetrics* SkFontHost::GetAdvancedTypefaceMetrics( info->fStyle |= SkAdvancedTypefaceMetrics::kFixedPitch_Style; if (face->style_flags & FT_STYLE_FLAG_ITALIC) info->fStyle |= SkAdvancedTypefaceMetrics::kItalic_Style; - // We should set either Symbolic or Nonsymbolic; Nonsymbolic if the font's - // character set is a subset of 'Adobe standard Latin.' - info->fStyle |= SkAdvancedTypefaceMetrics::kSymbolic_Style; PS_FontInfoRec ps_info; TT_Postscript* tt_info; diff --git a/src/ports/SkFontHost_mac.cpp b/src/ports/SkFontHost_mac.cpp index 83c811a684..4a6b8d8b68 100755 --- a/src/ports/SkFontHost_mac.cpp +++ b/src/ports/SkFontHost_mac.cpp @@ -1520,9 +1520,6 @@ SkAdvancedTypefaceMetrics* SkFontHost::GetAdvancedTypefaceMetrics( info->fStyle |= SkAdvancedTypefaceMetrics::kItalic_Style; } CTFontStylisticClass stylisticClass = symbolicTraits & kCTFontClassMaskTrait; - if (stylisticClass & kCTFontSymbolicClass) { - info->fStyle |= SkAdvancedTypefaceMetrics::kSymbolic_Style; - } if (stylisticClass >= kCTFontOldStyleSerifsClass && stylisticClass <= kCTFontSlabSerifsClass) { info->fStyle |= SkAdvancedTypefaceMetrics::kSerif_Style; } else if (stylisticClass & kCTFontScriptsClass) { diff --git a/src/ports/SkFontHost_win.cpp b/src/ports/SkFontHost_win.cpp index 0f7295f5a0..d0fbd47e2d 100755 --- a/src/ports/SkFontHost_win.cpp +++ b/src/ports/SkFontHost_win.cpp @@ -1406,8 +1406,6 @@ SkAdvancedTypefaceMetrics* SkFontHost::GetAdvancedTypefaceMetrics( if (otm.otmTextMetrics.tmItalic) { info->fStyle |= SkAdvancedTypefaceMetrics::kItalic_Style; } - // Setting symbolic style by default for now. - info->fStyle |= SkAdvancedTypefaceMetrics::kSymbolic_Style; if (otm.otmTextMetrics.tmPitchAndFamily & FF_ROMAN) { info->fStyle |= SkAdvancedTypefaceMetrics::kSerif_Style; } else if (otm.otmTextMetrics.tmPitchAndFamily & FF_SCRIPT) { diff --git a/src/ports/SkFontHost_win_dw.cpp b/src/ports/SkFontHost_win_dw.cpp index 1f257eb3d1..4bf91511c1 100644 --- a/src/ports/SkFontHost_win_dw.cpp +++ b/src/ports/SkFontHost_win_dw.cpp @@ -1488,8 +1488,6 @@ SkAdvancedTypefaceMetrics* SkFontHost::GetAdvancedTypefaceMetrics( if (os2Table->version.v0.fsSelection.field.Italic) { info->fStyle |= SkAdvancedTypefaceMetrics::kItalic_Style; } - //Symbolic (uses more than base latin). - info->fStyle |= SkAdvancedTypefaceMetrics::kSymbolic_Style; //Script if (SkPanose::FamilyType::Script == os2Table->version.v0.panose.bFamilyType.value) { info->fStyle |= SkAdvancedTypefaceMetrics::kScript_Style; |