diff options
author | djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2012-08-07 15:54:32 +0000 |
---|---|---|
committer | djsollen@google.com <djsollen@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2012-08-07 15:54:32 +0000 |
commit | c73dd5c6880739f26216f198c757028fd28df1a4 (patch) | |
tree | 17a4984fe2caecb5d36a27324eaa698550d4db04 /src/ports | |
parent | 7b4531f64cbd85d32a77ceab1bdec8335c5a7864 (diff) |
Update SkFlattenable buffers to be more modular.
This CL is an effort to stage the conversion to named
parameters for all SkFlattenable commands. This particular
stage only does the following two things...
1. Move flattenable buffers from SkFlattenable.h into
their own header.
2. Update and Add new read write methods for better clarity
and convenience.
BUG=
Review URL: https://codereview.appspot.com/6448095
git-svn-id: http://skia.googlecode.com/svn/trunk@4980 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/ports')
-rw-r--r-- | src/ports/SkImageRef_ashmem.cpp | 22 |
1 files changed, 5 insertions, 17 deletions
diff --git a/src/ports/SkImageRef_ashmem.cpp b/src/ports/SkImageRef_ashmem.cpp index 6ea5c95e78..81f24dd630 100644 --- a/src/ports/SkImageRef_ashmem.cpp +++ b/src/ports/SkImageRef_ashmem.cpp @@ -214,14 +214,7 @@ void SkImageRef_ashmem::onUnlockPixels() { void SkImageRef_ashmem::flatten(SkFlattenableWriteBuffer& buffer) const { this->INHERITED::flatten(buffer); - const char* uri = getURI(); - if (uri) { - size_t len = strlen(uri); - buffer.write32(len); - buffer.writePad(uri, len); - } else { - buffer.write32(0); - } + buffer.writeString(getURI()); } SkImageRef_ashmem::SkImageRef_ashmem(SkFlattenableReadBuffer& buffer) @@ -231,17 +224,12 @@ SkImageRef_ashmem::SkImageRef_ashmem(SkFlattenableReadBuffer& buffer) fRec.fSize = 0; fRec.fPinned = false; fCT = NULL; - size_t length = buffer.readU32(); - if (length) { - char* buf = (char*) malloc(length); - buffer.read(buf, length); - setURI(buf, length); + const char* uri = buffer.readString(); + if (uri) { + setURI(uri); + sk_free(uri); } this->useDefaultMutex(); // we don't need/want the shared imageref mutex } -SkPixelRef* SkImageRef_ashmem::Create(SkFlattenableReadBuffer& buffer) { - return SkNEW_ARGS(SkImageRef_ashmem, (buffer)); -} - SK_DEFINE_FLATTENABLE_REGISTRAR(SkImageRef_ashmem) |