sk_fgetsize to not use ftell.

The previous version of sk_fgetsize used ftell and fseek to compute
the size of a file. There are so many issues with this that it is called
out by securecoding.cert.org as FIO19-C as a thing not to do. We already
have correct code for computing the size of a file in the mmap code, so
use that instead.

Change-Id: I1d771124989d0ec1523f6d858814ee563263213a
Reviewed-on: https://skia-review.googlesource.com/9860
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>

1 files changed, 0 insertions, 18 deletions

diff --git a/src/ports/SkOSFile_stdio.cpp b/src/ports/SkOSFile_stdio.cpp
index 68c2d3d4d7..e79d87fc89 100644
--- a/src/ports/SkOSFile_stdio.cpp
+++ b/src/ports/SkOSFile_stdio.cpp
@@ -87,24 +87,6 @@ FILE* sk_fopen(const char path[], SkFILE_Flags flags) {
     return file;
 }
 
-size_t sk_fgetsize(FILE* f) {
-    SkASSERT(f);
-
-    long curr = ftell(f); // remember where we are
-    if (curr < 0) {
-        return 0;
-    }
-
-    fseek(f, 0, SEEK_END); // go to the end
-    long size = ftell(f); // record the size
-    if (size < 0) {
-        size = 0;
-    }
-
-    fseek(f, curr, SEEK_SET); // go back to our prev location
-    return size;
-}
-
 size_t sk_fwrite(const void* buffer, size_t byteCount, FILE* f) {
     SkASSERT(f);
     return fwrite(buffer, 1, byteCount, f);