diff options
author | Ben Wagner <bungeman@google.com> | 2017-03-01 16:08:00 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-03-01 22:11:25 +0000 |
commit | e0c9e00cd5ed17a45a988b8b57fa9c09f3574921 (patch) | |
tree | 0cf1e54ae42f4bd6397b3dd280f240f05967ad95 /src/ports/SkFontMgr_win_dw.cpp | |
parent | 2a098d09edfb7f02139a9537df6f1c0ac514fd74 (diff) |
Remove SK_HAS_DWRITE_X defines.
While developing DirectWrite it was ncessary to support building with
older Windows SDKs which may not have certain headers. Now that the
minimum required Windows SDK is 8.1 (0x0603) we can remove these
difficult to use macros to simplify future development.
Change-Id: Ia780466b7c9b86198116c5974c43363f49a0ebac
Reviewed-on: https://skia-review.googlesource.com/9124
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Diffstat (limited to 'src/ports/SkFontMgr_win_dw.cpp')
-rw-r--r-- | src/ports/SkFontMgr_win_dw.cpp | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/src/ports/SkFontMgr_win_dw.cpp b/src/ports/SkFontMgr_win_dw.cpp index 905f413693..6ccd7fc99e 100644 --- a/src/ports/SkFontMgr_win_dw.cpp +++ b/src/ports/SkFontMgr_win_dw.cpp @@ -22,10 +22,7 @@ #include "SkUtils.h" #include <dwrite.h> - -#if SK_HAS_DWRITE_2_H #include <dwrite_2.h> -#endif //////////////////////////////////////////////////////////////////////////////// @@ -266,23 +263,19 @@ public: SkFontMgr_DirectWrite(IDWriteFactory* factory, IDWriteFontCollection* fontCollection, IDWriteFontFallback* fallback, WCHAR* localeName, int localeNameLength) : fFactory(SkRefComPtr(factory)) -#if SK_HAS_DWRITE_2_H , fFontFallback(SkSafeRefComPtr(fallback)) -#endif , fFontCollection(SkRefComPtr(fontCollection)) , fLocaleName(localeNameLength) { -#if SK_HAS_DWRITE_2_H if (!SUCCEEDED(fFactory->QueryInterface(&fFactory2))) { // IUnknown::QueryInterface states that if it fails, punk will be set to nullptr. // http://blogs.msdn.com/b/oldnewthing/archive/2004/03/26/96777.aspx SkASSERT_RELEASE(nullptr == fFactory2.get()); } if (fFontFallback.get()) { - // factory must be provied if fallback is non-null, else the fallback will not be used. + // factory must be provided if fallback is non-null, else the fallback will not be used. SkASSERT(fFactory2.get()); } -#endif memcpy(fLocaleName.get(), localeName, localeNameLength * sizeof(WCHAR)); } @@ -313,10 +306,8 @@ private: IDWriteFontFamily* fontFamily) const; SkTScopedComPtr<IDWriteFactory> fFactory; -#if SK_HAS_DWRITE_2_H SkTScopedComPtr<IDWriteFactory2> fFactory2; SkTScopedComPtr<IDWriteFontFallback> fFontFallback; -#endif SkTScopedComPtr<IDWriteFontCollection> fFontCollection; SkSMallocWCHAR fLocaleName; mutable SkMutex fTFCacheMutex; @@ -768,7 +759,6 @@ SkTypeface* SkFontMgr_DirectWrite::onMatchFamilyStyleCharacter(const char family dwBcp47 = &dwBcp47Local; } -#if SK_HAS_DWRITE_2_H if (fFactory2.get()) { SkTScopedComPtr<IDWriteFontFallback> systemFontFallback; IDWriteFontFallback* fontFallback = fFontFallback.get(); @@ -811,9 +801,6 @@ SkTypeface* SkFontMgr_DirectWrite::onMatchFamilyStyleCharacter(const char family HRNM(font->GetFontFamily(&fontFamily), "Could not get family from font."); return this->createTypefaceFromDWriteFont(fontFace.get(), font.get(), fontFamily.get()); } -#else -# pragma message("No dwrite_2.h is available, font fallback may be affected.") -#endif SkTScopedComPtr<IDWriteTextFormat> fallbackFormat; HRNM(fFactory->CreateTextFormat(dwFamilyName ? dwFamilyName : L"", |