aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/ports/SkFontConfigParser_android.cpp
diff options
context:
space:
mode:
authorGravatar tomhudson <tomhudson@chromium.org>2014-08-13 11:06:43 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-08-13 11:06:43 -0700
commit7a4747f4f62e4896d8f8469e1939b8191fff8d4e (patch)
treeb766f448d16b2236c699f721076072f7d7d3f79b /src/ports/SkFontConfigParser_android.cpp
parent69a5560ea5a8d26b120f5158e506a163d32b4a27 (diff)
Update path to Android font config file
In version LMP, Android is expected to change the path to their font configuration file (and condense several files into one), as well as changing the format (qv http://crrev.com/446473003/). This patch tries the new path before falling back to the old path. The new fonts are incompatible with assumptions made by the old SkFontConfigInterfaceAndroid, so this patch MUST NOT land until https://crrev.com/462073002/ or the equivalent has turned on the new SkFontManager. BUG=chromium:400801 R=djsollen@google.com, bungeman@google.com, tomhudson@google.com Committed: https://skia.googlesource.com/skia/+/94fa4b99e2a53e997a90c7808cc5263f1bf40c9f Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/458543002
Diffstat (limited to 'src/ports/SkFontConfigParser_android.cpp')
-rw-r--r--src/ports/SkFontConfigParser_android.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/ports/SkFontConfigParser_android.cpp b/src/ports/SkFontConfigParser_android.cpp
index e9c912f4b0..658055d5a2 100644
--- a/src/ports/SkFontConfigParser_android.cpp
+++ b/src/ports/SkFontConfigParser_android.cpp
@@ -19,7 +19,7 @@
// From Android version LMP onwards, all font files collapse into
-// /system/fonts/fonts.xml. Instead of trying to detect which version
+// /system/etc/fonts.xml. Instead of trying to detect which version
// we're on, try to open fonts.xml; if that fails, fall back to the
// older filename.
#define LMP_SYSTEM_FONTS_FILE "/system/etc/fonts.xml"
@@ -465,9 +465,10 @@ static void parseConfigFile(const char* filename, SkTDArray<FontFamily*> &famili
}
static void getSystemFontFamilies(SkTDArray<FontFamily*> &fontFamilies) {
+ int initialCount = fontFamilies.count();
parseConfigFile(LMP_SYSTEM_FONTS_FILE, fontFamilies);
- if (0 == fontFamilies.count()) {
+ if (initialCount == fontFamilies.count()) {
parseConfigFile(OLD_SYSTEM_FONTS_FILE, fontFamilies);
}
}