diff options
author | 2015-01-09 10:06:39 -0800 | |
---|---|---|
committer | 2015-01-09 10:06:40 -0800 | |
commit | 72c9faab45124e08c85f70ca38536914862d947c (patch) | |
tree | 611893b84bb33b1592d058ee0f2382f7f86601b8 /src/pipe | |
parent | 4490da227f1475fb66af20532c14d6d9febd18b6 (diff) |
Fix up all the easy virtual ... SK_OVERRIDE cases.
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
Diffstat (limited to 'src/pipe')
-rw-r--r-- | src/pipe/SkGPipeRead.cpp | 4 | ||||
-rw-r--r-- | src/pipe/SkGPipeWrite.cpp | 34 | ||||
-rw-r--r-- | src/pipe/utils/SamplePipeControllers.h | 14 |
3 files changed, 26 insertions, 26 deletions
diff --git a/src/pipe/SkGPipeRead.cpp b/src/pipe/SkGPipeRead.cpp index dab6178cfe..aa108e602e 100644 --- a/src/pipe/SkGPipeRead.cpp +++ b/src/pipe/SkGPipeRead.cpp @@ -162,7 +162,7 @@ public: * these SkBitmaps for bitmap shaders. Used only in cross process mode * without a shared heap. */ - virtual SkBitmap* getBitmap(int32_t index) const SK_OVERRIDE { + SkBitmap* getBitmap(int32_t index) const SK_OVERRIDE { SkASSERT(shouldFlattenBitmaps(fFlags)); return fBitmaps[index]; } @@ -170,7 +170,7 @@ public: /** * Needed to be a non-abstract subclass of SkBitmapHeapReader. */ - virtual void releaseRef(int32_t) SK_OVERRIDE {} + void releaseRef(int32_t) SK_OVERRIDE {} void setSharedHeap(SkBitmapHeap* heap) { SkASSERT(!shouldFlattenBitmaps(fFlags) || NULL == heap); diff --git a/src/pipe/SkGPipeWrite.cpp b/src/pipe/SkGPipeWrite.cpp index 6044360933..be687f7d31 100644 --- a/src/pipe/SkGPipeWrite.cpp +++ b/src/pipe/SkGPipeWrite.cpp @@ -86,9 +86,9 @@ public: fPointers.freeAll(); } - virtual void* allocThrow(size_t bytes) SK_OVERRIDE; + void* allocThrow(size_t bytes) SK_OVERRIDE; - virtual void unalloc(void* ptr) SK_OVERRIDE; + void unalloc(void* ptr) SK_OVERRIDE; void setBitmapStorage(SkBitmapHeap* heap) { this->setBitmapHeap(heap); @@ -175,7 +175,7 @@ public: ~BitmapShuttle(); - virtual bool insert(const SkBitmap& bitmap, int32_t slot) SK_OVERRIDE; + bool insert(const SkBitmap& bitmap, int32_t slot) SK_OVERRIDE; /** * Remove the SkGPipeCanvas used for insertion. After this, calls to @@ -231,9 +231,9 @@ public: return (NULL == fBitmapHeap) ? 0 : fBitmapHeap->bytesAllocated(); } - virtual void beginCommentGroup(const char* description) SK_OVERRIDE; - virtual void addComment(const char* kywd, const char* value) SK_OVERRIDE; - virtual void endCommentGroup() SK_OVERRIDE; + void beginCommentGroup(const char* description) SK_OVERRIDE; + void addComment(const char* kywd, const char* value) SK_OVERRIDE; + void endCommentGroup() SK_OVERRIDE; /** * Flatten an SkBitmap to send to the reader, where it will be referenced @@ -242,14 +242,14 @@ public: bool shuttleBitmap(const SkBitmap&, int32_t slot); protected: - virtual void willSave() SK_OVERRIDE; - virtual SaveLayerStrategy willSaveLayer(const SkRect*, const SkPaint*, SaveFlags) SK_OVERRIDE; - virtual void willRestore() SK_OVERRIDE; + void willSave() SK_OVERRIDE; + SaveLayerStrategy willSaveLayer(const SkRect*, const SkPaint*, SaveFlags) SK_OVERRIDE; + void willRestore() SK_OVERRIDE; - virtual void didConcat(const SkMatrix&) SK_OVERRIDE; - virtual void didSetMatrix(const SkMatrix&) SK_OVERRIDE; + void didConcat(const SkMatrix&) SK_OVERRIDE; + void didSetMatrix(const SkMatrix&) SK_OVERRIDE; - virtual void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&) SK_OVERRIDE; + void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&) SK_OVERRIDE; virtual void onDrawText(const void* text, size_t byteLength, SkScalar x, SkScalar y, const SkPaint&) SK_OVERRIDE; virtual void onDrawPosText(const void* text, size_t byteLength, const SkPoint pos[], @@ -286,12 +286,12 @@ protected: const SkColor colors[], SkXfermode* xmode, const uint16_t indices[], int indexCount, const SkPaint&) SK_OVERRIDE; - virtual void onClipRect(const SkRect&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; - virtual void onClipRRect(const SkRRect&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; - virtual void onClipPath(const SkPath&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; - virtual void onClipRegion(const SkRegion&, SkRegion::Op) SK_OVERRIDE; + void onClipRect(const SkRect&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; + void onClipRRect(const SkRRect&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; + void onClipPath(const SkPath&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE; + void onClipRegion(const SkRegion&, SkRegion::Op) SK_OVERRIDE; - virtual void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) SK_OVERRIDE; + void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) SK_OVERRIDE; private: void recordTranslate(const SkMatrix&); diff --git a/src/pipe/utils/SamplePipeControllers.h b/src/pipe/utils/SamplePipeControllers.h index 35cfba73b6..3442c49d67 100644 --- a/src/pipe/utils/SamplePipeControllers.h +++ b/src/pipe/utils/SamplePipeControllers.h @@ -18,8 +18,8 @@ class PipeController : public SkGPipeController { public: PipeController(SkCanvas* target, SkPicture::InstallPixelRefProc proc = NULL); virtual ~PipeController(); - virtual void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; - virtual void notifyWritten(size_t bytes) SK_OVERRIDE; + void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; + void notifyWritten(size_t bytes) SK_OVERRIDE; protected: const void* getData() { return (const char*) fBlock + fBytesWritten; } SkGPipeReader fReader; @@ -37,8 +37,8 @@ public: TiledPipeController(const SkBitmap&, SkPicture::InstallPixelRefProc proc = NULL, const SkMatrix* initialMatrix = NULL); virtual ~TiledPipeController() {}; - virtual void notifyWritten(size_t bytes) SK_OVERRIDE; - virtual int numberOfReaders() const SK_OVERRIDE { return NumberOfTiles; } + void notifyWritten(size_t bytes) SK_OVERRIDE; + int numberOfReaders() const SK_OVERRIDE { return NumberOfTiles; } private: enum { NumberOfTiles = 10 @@ -57,9 +57,9 @@ private: class ThreadSafePipeController : public SkGPipeController { public: ThreadSafePipeController(int numberOfReaders); - virtual void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; - virtual void notifyWritten(size_t bytes) SK_OVERRIDE; - virtual int numberOfReaders() const SK_OVERRIDE { return fNumberOfReaders; } + void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; + void notifyWritten(size_t bytes) SK_OVERRIDE; + int numberOfReaders() const SK_OVERRIDE { return fNumberOfReaders; } /** * Play the stored drawing commands to the specified canvas. If SkGPipeWriter::startRecording |