diff options
| author |  reed <reed@google.com> | 2016-09-22 14:12:46 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-09-22 14:12:47 -0700 |
| commit | d14df7c700bf77c8c42c791ca7a865c1bbc96679 (patch) | |
| tree | 553e6ab4662bc2737c7fccc8f90ba780726c853b /src/pdf | |
| parent | ae6e4869c94596eb3bf5069888b32ab06199aec0 (diff) | |
document.close from bool to void
Nothing meaningful is returned, it is inconsistent with the bulk of the rest of skia's api. The C api is waiting on this change as well.
Required chrome CL: https://codereview.chromium.org/2355343003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
Review-Url: https://codereview.chromium.org/2354403002
Diffstat (limited to 'src/pdf')
| -rw-r--r-- | src/pdf/SkPDFDocument.cpp | 5 | ||||
| -rw-r--r-- | src/pdf/SkPDFDocument.h | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/pdf/SkPDFDocument.cpp b/src/pdf/SkPDFDocument.cpp index 8734927901..ab5f465971 100644 --- a/src/pdf/SkPDFDocument.cpp +++ b/src/pdf/SkPDFDocument.cpp @@ -399,11 +399,11 @@ static sk_sp<SkPDFArray> make_srgb_output_intents() { return intentArray; } -bool SkPDFDocument::onClose(SkWStream* stream) { +void SkPDFDocument::onClose(SkWStream* stream) { SkASSERT(!fCanvas.get()); if (fPages.empty()) { this->reset(); - return false; + return; } auto docCatalog = sk_make_sp<SkPDFDict>("Catalog"); if (fPDFA) { @@ -428,7 +428,6 @@ bool SkPDFDocument::onClose(SkWStream* stream) { fObjectSerializer.serializeObjects(this->getStream()); fObjectSerializer.serializeFooter(this->getStream(), docCatalog, fID); this->reset(); - return true; } /////////////////////////////////////////////////////////////////////////////// diff --git a/src/pdf/SkPDFDocument.h b/src/pdf/SkPDFDocument.h index eeafbca624..b62a7a59a2 100644 --- a/src/pdf/SkPDFDocument.h +++ b/src/pdf/SkPDFDocument.h @@ -53,7 +53,7 @@ public: virtual ~SkPDFDocument(); SkCanvas* onBeginPage(SkScalar, SkScalar, const SkRect&) override; void onEndPage() override; - bool onClose(SkWStream*) override; + void onClose(SkWStream*) override; void onAbort() override; /** |