aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/pdf
diff options
context:
space:
mode:
authorGravatar Hal Canary <halcanary@google.com>2017-10-03 09:38:43 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-10-10 16:41:13 +0000
commitc5b94988915920ed359eecec34d4fbd6bdc0a3fd (patch)
treec735d56ca0735d5046e0540d6258e17773f0a805 /src/pdf
parent24f0a354ac618c17a71e4dac80dd0ad370ed14eb (diff)
SkPDF: consolidate two functions in SkPDFObjNumMap
Change-Id: Id815920e664ba986258867b7c35a7618a6927b0f Reviewed-on: https://skia-review.googlesource.com/54360 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
Diffstat (limited to 'src/pdf')
-rw-r--r--src/pdf/SkPDFTypes.cpp13
-rw-r--r--src/pdf/SkPDFTypes.h6
2 files changed, 3 insertions, 16 deletions
diff --git a/src/pdf/SkPDFTypes.cpp b/src/pdf/SkPDFTypes.cpp
index c256ff925d..c1505ea413 100644
--- a/src/pdf/SkPDFTypes.cpp
+++ b/src/pdf/SkPDFTypes.cpp
@@ -576,17 +576,10 @@ void SkPDFStream::setData(std::unique_ptr<SkStreamAsset> stream) {
////////////////////////////////////////////////////////////////////////////////
-bool SkPDFObjNumMap::addObject(SkPDFObject* obj) {
- if (fObjectNumbers.find(obj)) {
- return false;
- }
- fObjectNumbers.set(obj, fObjectNumbers.count() + 1);
- fObjects.emplace_back(sk_ref_sp(obj));
- return true;
-}
-
void SkPDFObjNumMap::addObjectRecursively(SkPDFObject* obj) {
- if (obj && this->addObject(obj)) {
+ if (obj && !fObjectNumbers.find(obj)) {
+ fObjectNumbers.set(obj, fObjectNumbers.count() + 1);
+ fObjects.emplace_back(sk_ref_sp(obj));
obj->addResources(this);
}
}
diff --git a/src/pdf/SkPDFTypes.h b/src/pdf/SkPDFTypes.h
index af5cdaf4f7..c393376abb 100644
--- a/src/pdf/SkPDFTypes.h
+++ b/src/pdf/SkPDFTypes.h
@@ -359,12 +359,6 @@ private:
*/
class SkPDFObjNumMap : SkNoncopyable {
public:
- /** Add the passed object to the catalog.
- * @param obj The object to add.
- * @return True iff the object was not already added to the catalog.
- */
- bool addObject(SkPDFObject* obj);
-
/** Add the passed object to the catalog, as well as all its dependencies.
* @param obj The object to add. If nullptr, this is a noop.
*/